[electroluxair] Initial contribution #11116

jannegpriv · 2021-08-15T14:35:22Z

Signed-off-by: Jan Gustafsson jannegpriv@gmail.com

Initial contribution of the electroluxair openHAB binding.

The binding uses the Electrolux Delta REST API and the binding implements support for the Electrolux Pure A9 Air Purifier and solves #10246.

In the community thread you can find a link to a built binding jar-file.

jannegpriv · 2021-08-15T14:36:02Z

@fwolter I've created a new PR and I would like to have it reviewed :-)

fwolter

You need to add your binding to the pom.xml in the root directory and to bom\openhab-addons\pom.xml. Then, you can check the static code analysis output after running mvn clean install.

Please add yourself to the CODEOWNERS file.

fwolter · 2021-09-09T17:21:13Z

bundles/org.openhab.binding.electroluxair/README.md

+<p align="center">
+<img src="doc/electrolux_pure_a9.webp" alt="Electrolux Pure A9" width="200px"/>
+</p>


Try to stick to markdown, even if the image is not centered.

Suggested change

<p align="center">

<img src="doc/electrolux_pure_a9.webp" alt="Electrolux Pure A9" width="200px"/>

</p>

![Electrolux Pure A9](electrolux_pure_a9.webp)

fwolter · 2021-09-09T17:21:55Z

bundles/org.openhab.binding.electroluxair/README.md

+## Supported Things
+
+This binding supports the following thing types:
+
+- Bridge
+- Electrolux Pure A9


You could add the Thing Type UIDs needed for textual configuration.

fwolter · 2021-09-09T17:22:54Z

bundles/org.openhab.binding.electroluxair/README.md

+## Binding Configuration
+
+You will have to configure the bridge with username and password, these must be the same credentials as used when logging into your Electrolux Wellbeing app. 


This chapter is inteded for the binding global configuration. As your binding doesn't have this, this chapter could be removed.

Chapter removed!

fwolter · 2021-09-09T17:24:10Z

bundles/org.openhab.binding.electroluxair/README.md

+#### Bridge
+
+*   `username` - The username used to connect to the Electrolux Wellbeing app
+
+*   `password` - The password used to connect to the Electrolux Wellbeing app
+
+*   `refresh` - Specifies the refresh interval in second


To be consistent with the other bindings, you could add a table with the type (Number, Text), the default value if any and if the parameter is required.

fwolter · 2021-09-09T17:25:32Z

bundles/org.openhab.binding.electroluxair/README.md

+If you define the bridge in a things-file the bridge type id is defined as `bridge`, e.g.:
+
+`Bridge electroluxair:bridge:myElectroluxAirBridge`


This could be removed if you mention the Thing Type UID above and by the example section below.

fwolter · 2021-09-09T18:14:50Z

...r/src/main/java/org/openhab/binding/electroluxair/internal/handler/ElectroluxAirHandler.java

+    }
+
+    private void update(@Nullable ElectroluxPureA9DTO dto) {
+        logger.debug("update: {}", dto);


See above. Remove. Please check all.

fwolter · 2021-09-09T18:17:53Z

...r/src/main/java/org/openhab/binding/electroluxair/internal/handler/ElectroluxAirHandler.java

+                    properties.put(PROPERTY_BRAND, dto.getApplicancesInfo().brand);
+                    properties.put(PROPERTY_COLOUR, dto.getApplicancesInfo().colour);
+                    properties.put(PROPERTY_DEVICE, dto.getApplicancesInfo().device);
+                    properties.put(PROPERTY_MODEL, dto.getApplicancesInfo().model);
+                    properties.put(PROPERTY_SERIAL_NUMBER, dto.getApplicancesInfo().serialNumber);
+                    properties.put(PROPERTY_FW_VERSION, dto.getTwin().getProperties().getReported().frmVerNIU);


There are predefined properties you could use.

Suggested change

properties.put(PROPERTY_BRAND, dto.getApplicancesInfo().brand);

properties.put(PROPERTY_COLOUR, dto.getApplicancesInfo().colour);

properties.put(PROPERTY_DEVICE, dto.getApplicancesInfo().device);

properties.put(PROPERTY_MODEL, dto.getApplicancesInfo().model);

properties.put(PROPERTY_SERIAL_NUMBER, dto.getApplicancesInfo().serialNumber);

properties.put(PROPERTY_FW_VERSION, dto.getTwin().getProperties().getReported().frmVerNIU);

properties.put(Thing.PROPERTY_VENDOR, dto.getApplicancesInfo().brand);

properties.put(PROPERTY_COLOUR, dto.getApplicancesInfo().colour);

properties.put(PROPERTY_DEVICE, dto.getApplicancesInfo().device);

properties.put(Thing.PROPERTY_MODEL_ID, dto.getApplicancesInfo().model);

properties.put(Thing.PROPERTY_SERIAL_NUMBER, dto.getApplicancesInfo().serialNumber);

properties.put(Thing.PROPERTY_FIRMWARE_VERSION,

dto.getTwin().getProperties().getReported().frmVerNIU);

fwolter · 2021-09-09T18:18:42Z

...ain/java/org/openhab/binding/electroluxair/internal/handler/ElectroluxAirHandlerFactory.java

+        } else if (THING_TYPE_BRIDGE.equals(thingTypeUID)) {
+            return new ElectroluxAirBridgeHandler((Bridge) thing, httpClient, gson);
+        }
+        logger.warn("ThingHandler not found for {}", thing.getThingTypeUID());


This is already logged by the framework.

fwolter · 2021-09-09T18:19:10Z

....openhab.binding.electroluxair/src/main/resources/OH-INF/i18n/electroluxair_xx_XX.properties

@@ -0,0 +1,17 @@
+# FIXME: please substitute the xx_XX with a proper locale, ie. de_DE


Can this file be removed?

Yes, I removed it.

fwolter · 2021-09-09T18:19:50Z

bundles/org.openhab.binding.electroluxair/src/main/resources/OH-INF/thing/thing-types.xml

+	</bridge-type>
+
+	<thing-type id="electroluxpurea9">
+		<label>ElectroluxAir Pure A9 Thing</label>


Labels are expected to be as short as possible. Guideline is 2-3 words with max 20-25 chars. See https://www.openhab.org/docs/developer/bindings/thing-xml.html#formatting-labels-and-descriptions

Suggested change

<label>ElectroluxAir Pure A9 Thing</label>

<label>ElectroluxAir Pure A9</label>

@fwolter What is the best way to fix the conflicts? Rebase from main and then force push? Or should I do a fetch/merge and then normal push?

You can do a rebase against main/upstream, resolve the conflicts locally and than do a force-push.

fwolter · 2021-10-17T11:37:54Z

Here are the commands for rebasing your branch:

If not already done, add the upstream openHAB addon repo as a remote to your local repo and fetch it:

git remote add upstream https://github.com/openhab/openhab-addons.git
git fetch upstream

The remotes (git remote --verbose) should look like this, now:

origin  https://github.com/[your name]/openhab-addons.git (fetch)
origin  https://github.com/[your name]/openhab-addons.git (push)
upstream        https://github.com/openhab/openhab-addons.git (fetch)
upstream        https://github.com/openhab/openhab-addons.git (push)

Then, you can rebase your PR's branch onto main:

git rebase upstream/main

Finally force-push the rebased branch to this PR's branch:

git push origin [your branch name of this PR] --force-with-lease

DON'T use merge! This can clutter the Git history and make the PR unusable.

bundles/org.openhab.binding.electroluxair/README.md

fwolter · 2021-12-11T13:20:02Z

bundles/org.openhab.binding.electroluxair/README.md

+## Supported Things
+
+This binding supports the following types:
+
+- Bridge
+- Electrolux Pure A9
+
+If you define the bridge in a things-file the bridge type id is defined as `bridge`, e.g.:
+
+`Bridge electroluxair:api:myAPI "Electrolux Delta API" [username="user@password.com", password="12345", refresh="300"`
+
+If you define the thing in a things-file the thing type id is defined as:
+
+`Thing electroluxpurea9 MyElectroluxPureA9  "Electrolux Pure A9"    [ deviceId="123456789" ]`


In this section you should only mention the ThingTypeUIDs and describe them shortly. The config examples could be moved to the "Full Examples" section.

fwolter · 2021-12-11T13:22:30Z

bundles/org.openhab.binding.electroluxair/README.md

+| password  | The password used to connect to the Electrolux Wellbeing app | String | NA       | yes      |
+| refresh   | Specifies the refresh interval in second                     | Number | 600      | yes      |
+
+## Thing Configuration


This seems to make sense in the "Configuration Options" chapter.

Suggested change

## Thing Configuration

#### Thing

fwolter · 2021-12-11T13:23:11Z

bundles/org.openhab.binding.electroluxair/README.md

+
+Only the bridge require manual configuration. The thing can be added by hand, or you can let the discovery mechanism automatically find your Electrolux Pure A9 thing.
+
+### Configuration Options


This heading is already present a few lines above.

fwolter · 2021-12-11T13:24:31Z

bundles/org.openhab.binding.electroluxair/README.md

+
+| Channel Type ID | Item Type | Description                                                                                     |
+|-----------------|-----------|-------------------------------------------------------------------------------------------------|
+| status          | String    | This channel can be used to trigger an instant refresh by sending a RefreshType.REFRESH command.|


Did you push your changes?

fwolter · 2021-12-11T13:25:10Z

bundles/org.openhab.binding.electroluxair/README.md

+| filterLife                  | Number:Dimensionless  | This channel reports the remaining filter life in %.                        |
+| ionizer                     | Switch                | This channel sets and reports the status of the ionizer function (On/Off).  |
+| doorOpen                    | Contact               | This channel reports the status of door (Opened/Closed).                    |
+| workMode                    | String                | This channel sets and reports the current work mode (Auto, Manual, PowerOff.|


fwolter · 2021-12-11T13:30:12Z

...main/java/org/openhab/binding/electroluxair/internal/handler/ElectroluxAirBridgeHandler.java

+    private final HttpClient httpClient;
+    private @Nullable ElectroluxDeltaAPI api;
+
+    private static int REFRESH_SEC = 300;


Then, this shouldn't be static. Otherwise this field would be global and the last loaded ThingHandler's config would overwrite all other ThingHandler's refresh fields.

fwolter · 2021-12-11T13:41:48Z

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

There are some compiler warnings about null access left. You could take a look at mvn clean install. To fix these, you need to store the field to a local variable and do the null check on that.

jannegpriv · 2021-12-28T11:10:17Z

target/code-analysis/report.html

I only see warnings on patterns for 3 variables.

fwolter · 2022-01-01T17:31:39Z

Did you finish making all changes?

jannegpriv · 2022-01-01T20:03:26Z

Did you finish making all changes?

Yes sir! :-)

fwolter

I only see warnings on patterns for 3 variables.

Yeah, I see them, too.

fwolter · 2022-01-03T15:52:03Z

bundles/org.openhab.binding.electroluxair/README.md

+This binding supports the following types:
+
+- Bridge
+- Electrolux Pure A9


Can you name the ThingTypeUIDs?

Something like this?

Something like this is sufficient:

api: Bridge - Implements ...

fwolter · 2022-01-03T15:53:52Z

bundles/org.openhab.binding.electroluxair/README.md

+
+| Channel Type ID | Item Type | Description                                                                                     |
+|-----------------|-----------|-------------------------------------------------------------------------------------------------|
+| status          | String    | This channel can be used to trigger an instant refresh by sending a RefreshType.REFRESH command.|


I still see the status channel in the readme. Did you push your changes?

fwolter · 2022-01-03T15:57:29Z

...oluxair/src/main/java/org/openhab/binding/electroluxair/internal/api/ElectroluxDeltaAPI.java

+    public ElectroluxDeltaAPI(ElectroluxAirBridgeConfiguration configuration, Gson gson, HttpClient httpClient)
+            throws IOException {
+        this.gson = gson;
+        this.configuration = configuration;
+        this.httpClient = httpClient;


What can throw an IOException here?

fwolter · 2022-01-06T19:09:24Z

Please use a regular commit instead of a force-push after implementing review feedback. Then, the reviewer can take a look at your changes instead of reviewing the entire code again.

jannegpriv · 2022-01-07T00:17:23Z

Please use a regular commit instead of a force-push after implementing review feedback. Then, the reviewer can take a look at your changes instead of reviewing the entire code again.

I get this error when doing a git push:

$ git push origin 10246-electroluxair 
To github.com:jannegpriv/openhab-addons.git
 ! [rejected]              10246-electroluxair -> 10246-electroluxair (non-fast-forward)
error: failed to push some refs to 'github.com:jannegpriv/openhab-addons.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

I did a git pull and resolved the merge conflict.
I also fixed a warning on unused logging.

fwolter · 2022-01-07T09:24:19Z

Your branch is broken, now. Here is a howto fix it https://community.openhab.org/t/rebase-your-code-or-how-to-fix-your-git-history-before-requesting-a-pull/129358

…ding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

…ding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

jannegpriv · 2022-01-07T10:32:35Z

Your branch is broken, now. Here is a howto fix it https://community.openhab.org/t/rebase-your-code-or-how-to-fix-your-git-history-before-requesting-a-pull/129358

Did a new rebase and a git push origin 10246-electroluxair --force-with-lease.

fwolter · 2022-01-07T17:36:20Z

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

jannegpriv · 2022-01-08T09:27:55Z

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

No I have 0 code warnings.

fwolter

LGTM

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

jannegpriv · 2022-01-09T09:03:59Z

LGTM

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

Cool! :-) Thank's for your review, I learned a lot! :-)

lolodomo · 2022-01-09T12:07:50Z

Please create a subsequent PR to add the default translation properties file.
You can produce it simply by running this command : mvn i18n:generate-default-translations

* [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review and also copyright to 2022. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>

- put each sentence in a seperate line - add note that only PNG images are supported. See openhab/openhab-addons#11116 (comment) - add examples to "Supported Things" - add RW column to example Channel table - add advanced and default config value - add note that textual config examples are mandatory - make .sitemap example optional (see small internal discussion) - put emphasis on initialize() shall return quickly - add note about logging to INFO - fix compiler warning Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

* [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review and also copyright to 2022. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* [skeleton] Add Thing config table to readme; minor improvements - put each sentence in a seperate line - add note that only PNG images are supported. See openhab/openhab-addons#11116 (comment) - add examples to "Supported Things" - add RW column to example Channel table - add advanced and default config value - add note that textual config examples are mandatory - make .sitemap example optional (see small internal discussion) - put emphasis on initialize() shall return quickly - add note about logging to INFO - fix compiler warning - Add default config value for initialization Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

* [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review and also copyright to 2022. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review and also copyright to 2022. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>

* [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review and also copyright to 2022. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review and also copyright to 2022. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * [electroluxair] Initial contribution of the electroluxair openHAB binding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review. Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after code review Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

…hab#2692) * [skeleton] Add Thing config table to readme; minor improvements - put each sentence in a seperate line - add note that only PNG images are supported. See openhab/openhab-addons#11116 (comment) - add examples to "Supported Things" - add RW column to example Channel table - add advanced and default config value - add note that textual config examples are mandatory - make .sitemap example optional (see small internal discussion) - put emphasis on initialize() shall return quickly - add note about logging to INFO - fix compiler warning - Add default config value for initialization Signed-off-by: Fabian Wolter <github@fabian-wolter.de> GitOrigin-RevId: f79d17f

jannegpriv requested a review from a team as a code owner August 15, 2021 14:35

hmerk added the new binding If someone has started to work on a binding. For a new binding PR. label Aug 18, 2021

fwolter requested changes Sep 9, 2021

View reviewed changes

jannegpriv force-pushed the 10246-electroluxair branch from 208bb55 to 9e3caa9 Compare October 10, 2021 21:49

jannegpriv force-pushed the 10246-electroluxair branch from 9e3caa9 to 9eff8e6 Compare October 17, 2021 11:58

fwolter requested changes Dec 11, 2021

View reviewed changes

jannegpriv force-pushed the 10246-electroluxair branch from 9eff8e6 to a2782d5 Compare December 28, 2021 14:48

fwolter requested changes Jan 3, 2022

View reviewed changes

jannegpriv force-pushed the 10246-electroluxair branch from a2782d5 to 1278fd0 Compare January 4, 2022 20:23

jannegpriv requested review from 3cky, bobadair, BobRak, bruestel, caffineehacker, cdjackson, clinique, Cossey, cpmeister, cweitkamp, DerOetzi, digitaldan and dominicdesu as code owners January 7, 2022 09:18

jannegpriv requested review from tratho, trokohl, wborn and Wire82 as code owners January 7, 2022 09:18

jannegpriv added 5 commits January 7, 2022 10:59

[electroluxair] Initial contribution of the electroluxair openHAB bin…

b96d6cc

…ding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

Updated after code review.

707168b

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

Updated after code review and also copyright to 2022.

08ff8f6

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

[electroluxair] Initial contribution of the electroluxair openHAB bin…

989b68f

…ding Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

Updated after code review.

866a70c

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

jannegpriv force-pushed the 10246-electroluxair branch from 6fd60ab to 866a70c Compare January 7, 2022 10:31

Updated after code review

5e6f64d

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

fwolter approved these changes Jan 9, 2022

View reviewed changes

fwolter merged commit f79ce45 into openhab:main Jan 9, 2022

fwolter added this to the 3.3 milestone Jan 9, 2022

fwolter mentioned this pull request Jan 16, 2022

[skeleton] Add Thing config table to readme; minor improvements openhab/openhab-core#2692

Merged

		## Binding Configuration

		You will have to configure the bridge with username and password, these must be the same credentials as used when logging into your Electrolux Wellbeing app.

		If you define the bridge in a things-file the bridge type id is defined as `bridge`, e.g.:

		`Bridge electroluxair:bridge:myElectroluxAirBridge`

		@@ -0,0 +1,17 @@
		# FIXME: please substitute the xx_XX with a proper locale, ie. de_DE

	<label>ElectroluxAir Pure A9 Thing</label>
	<label>ElectroluxAir Pure A9</label>


		Only the bridge require manual configuration. The thing can be added by hand, or you can let the discovery mechanism automatically find your Electrolux Pure A9 thing.

		### Configuration Options

	\| workMode \| String \| This channel sets and reports the current work mode (Auto, Manual, PowerOff.\|
	\| workMode \| String \| This channel sets and reports the current work mode (Auto, Manual, PowerOff.) \|

[electroluxair] Initial contribution #11116

[electroluxair] Initial contribution #11116

Conversation

jannegpriv commented Aug 15, 2021

jannegpriv commented Aug 15, 2021

fwolter left a comment

Choose a reason for hiding this comment

fwolter Sep 9, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fwolter commented Oct 17, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fwolter commented Dec 11, 2021

jannegpriv commented Dec 28, 2021

fwolter commented Jan 1, 2022

jannegpriv commented Jan 1, 2022

fwolter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fwolter commented Jan 6, 2022

jannegpriv commented Jan 7, 2022 • edited Loading

fwolter commented Jan 7, 2022

jannegpriv commented Jan 7, 2022

fwolter commented Jan 7, 2022

jannegpriv commented Jan 8, 2022

fwolter left a comment

Choose a reason for hiding this comment

jannegpriv commented Jan 9, 2022

lolodomo commented Jan 9, 2022

fwolter Sep 9, 2021 •

edited

Loading

jannegpriv commented Jan 7, 2022 •

edited

Loading