[Tapocontrol] Binding to control Tapo (by TP-Link) Devices #11111

wildcs · 2021-08-15T10:32:09Z

TapoControl

this is the initial contribution of a new binding to control "Tapo SmartDevices"

Control Tapo (TP-Link) P100 WiFi-Sockets, L510 and 530 SmartBulbs with openhab

It's possible to switch the devices On/Off, change colors and brighness (if supported) and gather some informations from the devices.
The connection will be established between openhab and the device directly by ip-adresses but credentials for Tapo-cloud are required because the communication is encrypted with them.

compiled with maven and testet with the vs-code-developer-ide and one openhabian device

link to the source
link to the .jar

openhab-bot · 2021-08-20T19:50:25Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tapocontrol-new-binding-for-tapo-smart-wifi-device/118389/1

fwolter

I reviewed the readme, so far.

bundles/org.openhab.binding.tapocontrol/README.md

fwolter

The credential configuration looks good!

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

There are some compiler warnings about null access left. You could take a look at mvn clean install. To fix these, you need to store the field to a local variable and do the null check on that.

The sign off message needs to be your full name and have a valid email address. You can post the complete line in the comments, I will adopt it during merging, then.

bundles/org.openhab.binding.tapocontrol/README.md

...control/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlConfiguration.java

...ocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlThingHandler.java

bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/thing-types.xml

...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoSmartBulb.java

bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/thing-types.xml

.gitignore

wildcs · 2021-11-08T18:28:58Z

Thanks very very much to @daMihe to help me fixing my github history.
Hope i learned enough to keep it clean now.

Signed-off-by: Christian Wild <christian@wild-bw.de>

fwolter

Great that you two figured it out! Looking forward seeing the fixing tutorial!

Is this ready for review again? I only reviewed the discovery for now.

...ontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java

...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java

wildcs · 2021-11-09T07:56:13Z

Is this ready for review again? I only reviewed the discovery for now.

Would be great if you can review it all. So i can fix all review remarks next week. Binding looks to work good in that version so no bigger changes should be necessary at the moment.

fwolter

There are some compiler warnings about null access left. You could take a look at mvn clean install. To fix these, you need to store the field to a local variable and do the null check on that.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

...ontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoControlHandlerFactory.java

...tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/TapoDiscoveryService.java

...ntrol/src/main/java/org/openhab/binding/tapocontrol/internal/device/TapoUniversalDevice.java

...ntrol/src/main/java/org/openhab/binding/tapocontrol/internal/structures/TapoLightEffect.java

...binding.tapocontrol/src/main/java/org/openhab/binding/tapocontrol/internal/test/TapoUDP.java

bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/config/config.xml

bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/thing/testdevice.xml

wildcs · 2021-11-19T23:27:05Z

So guys. I think i resolved all review-requests.
Hope code is clean now.
No entrys in analysis-report, test things were "outsourced" into \src\test, testers seems to be satisfied :P
Let me know if there are still problems.

Anyway big THX to all reviewers (of any plugin etc.) for the time you spent into this and help others to get better 👍 👍

Signed-off-by: Christian Wild <christian@wild-bw.de>

fwolter

There are some compiler warnings about null access left. You could take a look at mvn clean install. To fix these, you need to store the field to a local variable and do the null check on that.

I re-reviewed the readme for now.

bundles/org.openhab.binding.tapocontrol/README.md

Signed-off-by: Christian Wild <christian@wild-bw.de>

fwolter

LGTM

fwolter · 2021-11-29T08:44:37Z

Now, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

added logo for tapocontrol-binding wich is merged with pull-request openhab/openhab-addons#11111

added logo for tapocontrol-binding wich is merged with pull-request openhab/openhab-addons#11111 Signed-off-by: Christian Wild <christianwild-bw.de>

…1111) * [tapocontrol] New Source Upload Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Snapshot 3.2 Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update CODEOWNERS Fixed bindingname Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update README.md Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] new "Bridge-Version" Credentials (TapoCloud) where now set in a bridge device. Things now had to be attached to a bridge. Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed device discovery bug fixed device discovery bug added bridge to thing-types.xml Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] code cleanup and optimization - general code cleanup and optimization - limited max connections and queued requests to 10 per destination - device error handling revised - review remarks of pull request processed Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] solved review requests Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] LightStrip L900 basicly supported Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed review requests Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed compiler warnings Signed-off-by: Christian Wild <christian@wild-bw.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>

…1111) * [tapocontrol] New Source Upload Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Snapshot 3.2 Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update CODEOWNERS Fixed bindingname Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update README.md Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] new "Bridge-Version" Credentials (TapoCloud) where now set in a bridge device. Things now had to be attached to a bridge. Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed device discovery bug fixed device discovery bug added bridge to thing-types.xml Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] code cleanup and optimization - general code cleanup and optimization - limited max connections and queued requests to 10 per destination - device error handling revised - review remarks of pull request processed Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] solved review requests Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] LightStrip L900 basicly supported Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed review requests Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed compiler warnings Signed-off-by: Christian Wild <christian@wild-bw.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>

…1111) * [tapocontrol] New Source Upload Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Delete bundles/org.openhab.binding.tapocontrol directory Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Snapshot 3.2 Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update CODEOWNERS Fixed bindingname Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update README.md Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] new "Bridge-Version" Credentials (TapoCloud) where now set in a bridge device. Things now had to be attached to a bridge. Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed device discovery bug fixed device discovery bug added bridge to thing-types.xml Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] Update bundles/org.openhab.binding.tapocontrol/README.md Co-authored-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] code cleanup and optimization - general code cleanup and optimization - limited max connections and queued requests to 10 per destination - device error handling revised - review remarks of pull request processed Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] solved review requests Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] LightStrip L900 basicly supported Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed review requests Signed-off-by: Christian Wild <christian@wild-bw.de> * [tapocontrol] fixed compiler warnings Signed-off-by: Christian Wild <christian@wild-bw.de> Co-authored-by: Fabian Wolter <github@fabian-wolter.de>

wildcs requested a review from a team as a code owner August 15, 2021 10:32

wildcs changed the title ~~Tapocontrol~~ [Tapocontrol] Binding to control Tapo (by TP-Link) Devices Aug 15, 2021

fwolter added the new binding If someone has started to work on a binding. For a new binding PR. label Aug 15, 2021

fwolter requested changes Sep 5, 2021

View reviewed changes

fwolter reviewed Sep 12, 2021

View reviewed changes

bundles/org.openhab.binding.tapocontrol/README.md Show resolved Hide resolved

fwolter requested changes Oct 30, 2021

View reviewed changes

wildcs requested review from bern77, bruestel, cdjackson, claell, clinique, computergeek1507, cweitkamp, daMihe, davidgraeff, digitaldan, gerrieg, Hilbrand, hmerk, kaikreuzer, kgoderis, lolodomo, lujop, marcelrv, markus7017, mherwege, mhilbush, octa22 and pacive as code owners November 1, 2021 10:51

wborn removed request for bobadair, chaton78, Confectrician and cschneider November 8, 2021 17:45

wborn reviewed Nov 8, 2021

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

[tapocontrol] LightStrip L900 basicly supported

34728ec

Signed-off-by: Christian Wild <christian@wild-bw.de>

fwolter requested changes Nov 8, 2021

View reviewed changes

fwolter requested changes Nov 13, 2021

View reviewed changes

wildcs requested a review from fwolter November 19, 2021 23:30

[tapocontrol] fixed review requests

0ae41c2

Signed-off-by: Christian Wild <christian@wild-bw.de>

fwolter requested changes Nov 21, 2021

View reviewed changes

bundles/org.openhab.binding.tapocontrol/README.md Outdated Show resolved Hide resolved

[tapocontrol] fixed compiler warnings

100a6b6

Signed-off-by: Christian Wild <christian@wild-bw.de>

wildcs requested a review from fwolter November 25, 2021 20:30

fwolter approved these changes Nov 28, 2021

View reviewed changes

fwolter merged commit 612afd2 into openhab:main Nov 28, 2021

fwolter added this to the 3.2 milestone Nov 28, 2021

wildcs mentioned this pull request Dec 1, 2021

Wrong Request. Please delete this openhab/openhab-docs#1685

Closed

wildcs added a commit to wildcs/openhab-docs that referenced this pull request Dec 2, 2021

Added logo for tapocontrol

20302c8

added logo for tapocontrol-binding wich is merged with pull-request openhab/openhab-addons#11111

wildcs mentioned this pull request Dec 2, 2021

Added logo for tapocontrol openhab/openhab-docs#1687

Merged

wildcs added a commit to wildcs/openhab-docs that referenced this pull request Dec 2, 2021

Added logo for tapocontrol

5e00cfb

added logo for tapocontrol-binding wich is merged with pull-request openhab/openhab-addons#11111 Signed-off-by: Christian Wild <christianwild-bw.de>

Confectrician pushed a commit to openhab/openhab-docs that referenced this pull request Dec 2, 2021

Added logo for tapocontrol (#1687)

052a2bb

added logo for tapocontrol-binding wich is merged with pull-request openhab/openhab-addons#11111 Signed-off-by: Christian Wild <christianwild-bw.de>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tapocontrol] Binding to control Tapo (by TP-Link) Devices #11111

[Tapocontrol] Binding to control Tapo (by TP-Link) Devices #11111

wildcs commented Aug 15, 2021

openhab-bot commented Aug 20, 2021

fwolter left a comment

fwolter left a comment

wildcs commented Nov 8, 2021

fwolter left a comment

wildcs commented Nov 9, 2021 •

edited

Loading

fwolter left a comment

wildcs commented Nov 19, 2021

fwolter left a comment

fwolter left a comment

fwolter commented Nov 29, 2021

[Tapocontrol] Binding to control Tapo (by TP-Link) Devices #11111

[Tapocontrol] Binding to control Tapo (by TP-Link) Devices #11111

Conversation

wildcs commented Aug 15, 2021

openhab-bot commented Aug 20, 2021

fwolter left a comment

Choose a reason for hiding this comment

fwolter left a comment

Choose a reason for hiding this comment

wildcs commented Nov 8, 2021

fwolter left a comment

Choose a reason for hiding this comment

wildcs commented Nov 9, 2021 • edited Loading

fwolter left a comment

Choose a reason for hiding this comment

wildcs commented Nov 19, 2021

fwolter left a comment

Choose a reason for hiding this comment

fwolter left a comment

Choose a reason for hiding this comment

fwolter commented Nov 29, 2021

wildcs commented Nov 9, 2021 •

edited

Loading