fix offline when image not available (#18066)

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
openhab · Jan 8, 2025 · ae81f39 · ae81f39
1 parent 2a4fea2
commit ae81f39
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/...ding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java b/...ding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
@@ -365,13 +365,19 @@ private void getSpeed() {
                 isp = tmpCont.getIsp();
                 interfaceInternalIp = tmpCont.getInterface().getInternalIp();
                 interfaceExternalIp = tmpCont.getInterface().getExternalIp();
-                resultUrl = tmpCont.getResult().getUrl();
-                String url = String.valueOf(resultUrl) + ".png";
-                logger.debug("Downloading result image from: {}", url);
-                RawType image = HttpUtil.downloadImage(url);
-                if (image != null) {
-                    resultImage = image;
+                if (tmpCont.getResult().isPersisted()) {
+                    resultUrl = tmpCont.getResult().getUrl();
+                    String url = String.valueOf(resultUrl) + ".png";
+                    logger.debug("Downloading result image from: {}", url);
+                    RawType image = HttpUtil.downloadImage(url);
+                    if (image != null) {
+                        resultImage = image;
+                    } else {
+                        resultImage = UnDefType.NULL;
+                    }
                 } else {
+                    logger.debug("Result image not persisted");
+                    resultUrl = "";
                     resultImage = UnDefType.NULL;
                 }
 

diff --git a/...g.speedtest/src/main/java/org/openhab/binding/speedtest/internal/dto/ResultContainer.java b/...g.speedtest/src/main/java/org/openhab/binding/speedtest/internal/dto/ResultContainer.java
@@ -263,6 +263,9 @@ public class Result {
         @SerializedName("url")
         @Expose
         private String url;
+        @SerializedName("persisted")
+        @Expose
+        private boolean persisted;
 
         public String getId() {
             return id;
@@ -279,6 +282,14 @@ public String getUrl() {
         public void setUrl(String url) {
             this.url = url;
         }
+
+        public boolean isPersisted() {
+            return persisted;
+        }
+
+        public void setPersisted(boolean persisted) {
+            this.persisted = persisted;
+        }
     }
 
     public class Server {