-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonization with OGC API Processes #27
Conversation
I cannot add you as a reviewer @jerstlouis, so I mention you in this comment: please have a look. |
Thanks @cportele Then I read @fmigneault 's comments again and I think the most convincing arguments for the extra
and I think we took the right decision after all. I had a look at the pull request and it looks good so far. After this is merged, I will have another go at updating the processes section in light of more recent changes to the process description (e.g. the switch from |
Thanks @jerstlouis. For Routes the "value" and "inputs" wrappers do not add any value, they just add noise. This seems to be different for Processes, because of the resource design in that standard. I still have doubts that it is the right decision to add the wrappers in Routes, too, because in general Routes and Processes are separate resources and there is a trivial mapping/conversion for those that want to implement Routing using a Processes backend, but I accept that we add them in order to move forward with both Routes and Processes. |
Please note - We will have this Issue as an Agenda Item for the SWG meeting. |
16 June 2021 SWG Meeting discussed this PR. There were comments and discussions as to whether this addition adds too much 'noise' to the API. Key points are that it does not affect Route Exchange Model (REM) and it also does not 'break' the API in the opinion of SWG members. Members requested a specific Use Case where this is used. Response was to support a client that supports only Routes API and a 'generic' client that support Processes API. Question brought up... Can this be added later? Answer is No. This is a 'Do now or never' decision. Observation made that we are not developing a Processes profile. Adding this elements closes an 'enormous gap' between Routes resource approach and Processes resource approach. Attendees noted the cost is small with respect to adding this, and there may be benefits. Caveat 1 - Would it help if a note was added to explain why we have these elements? Yes. Very important to include this before or as we merge. The Use Case is to allow both generic Processes client and Routes client to function with API. NOTUC to Merging this PR. |
... and the reasons for the additional members "inputs" and "value". If there are proposals for improving the text, please prepare a PR.
This pull request closes #15 and closes #17.