-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to docs and an example #73
Conversation
Amazing, thank you @Yoshanuikabundi!
This would be great -- yes please!
The For the |
Mmm OK maybe we should leave further docs changes for a future PR then! I'll see if I can put together a quick examples runner to finish this one off. |
"No... There is another" - Yoda
Thanks @Yoshanuikabundi! The changes all look good to me so far, let me know when you're after an official review :-) |
@Yoshanuikabundi just picking this back up again, should I keep waiting to review in case you're planning any future changes or is this good to go? :-) |
@Yoshanuikabundi I'll merge this for now so I can work off it for updating examples. |
I think the changes in this PR fixed #92 too, hurray! Thank you very much @Yoshanuikabundi for the great work here. |
Ah awesome! Sorry, I completely dropped this on the floor and forgot about it. |
I found over at openff-docs that train-gnn-notebook.ipynb had broken at some point since 0.2.2. This fixes that. I think this'll let us bring the central examples up to date with nagl but I'm not sure. Then I found that the API docs were not very complete - they were failing to a bug in Sphinx 5, so I've upgraded to Sphinx 6 and MyST 1.0... which then opened a big can of worms.
Changes made in this Pull Request:
version
argument totrain-gnn-notebook.ipynb
(<Link text>)[inv:<package>#<reference>]
instead of(<Link text>)[<package>:<reference>]
)So it's:
not
Questions:
theory.md
andtraining.md
because the relevant parts of the API seem to have been moved - how should they be updated?PR Checklist