Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 6025 - settings for the folksonomy server #6027

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now we can set the folksonomy server host.

Screenshots

dev mode (read) dev mode (write)
Screenshot_1733680574 Screenshot_1733680583

Fixes bug(s)

Impacted files

  • folksonomy_provider.dart: used a specific folksonomy server instead of systematically the prod server
  • product_query.dart: specific folksonomy server
  • user_preferences_dev_mode.dart: settings for the specific folksonomy server

Impacted files:
* `folksonomy_provider.dart`: used a specific folksonomy server instead of systematically the prod server
* `product_query.dart`: specific folksonomy server
* `user_preferences_dev_mode.dart`: settings for the specific folksonomy server
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 6.49%. Comparing base (4d9c7fc) to head (b3ce269).
Report is 560 commits behind head on develop.

Files with missing lines Patch % Lines
...b/pages/preferences/user_preferences_dev_mode.dart 0.00% 17 Missing ⚠️
..._app/lib/pages/folksonomy/folksonomy_provider.dart 0.00% 10 Missing ⚠️
packages/smooth_app/lib/query/product_query.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6027      +/-   ##
==========================================
- Coverage     9.54%   6.49%   -3.06%     
==========================================
  Files          325     441     +116     
  Lines        16411   25009    +8598     
==========================================
+ Hits          1567    1624      +57     
- Misses       14844   23385    +8541     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon added folksonomy engine Free form modelling of products: https://wiki.openfoodfacts.org/Folksonomy_Engine dev mode labels Dec 9, 2024
@teolemon teolemon merged commit 736f08c into openfoodfacts:develop Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev mode folksonomy engine Free form modelling of products: https://wiki.openfoodfacts.org/Folksonomy_Engine
Development

Successfully merging this pull request may close these issues.

Allow customizing the Folksonomy Engine Base URL
3 participants