Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve /image_predictions route #1489

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

raphael0202
Copy link
Collaborator

@raphael0202 raphael0202 commented Dec 6, 2024

  • don't perform a join by default with logo_annotation table when calling the endpoint.
  • allow to filter by image_id in /api/v1/image_predictions

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.68%. Comparing base (33645a6) to head (b21c456).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
robotoff/app/core.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1489   +/-   ##
=======================================
  Coverage   54.67%   54.68%           
=======================================
  Files          85       85           
  Lines        8797     8800    +3     
=======================================
+ Hits         4810     4812    +2     
- Misses       3987     3988    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 changed the title fix: set better default for with_logo param in /image_predictions route feat: improve /image_predictions route Dec 6, 2024
@raphael0202 raphael0202 merged commit 63add1f into main Dec 6, 2024
10 checks passed
@raphael0202 raphael0202 deleted the image-predictions-route branch December 6, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant