Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Android SDK to 34, Google Play won't accept lower. Fixed some typos. Set ios.non-exempt-encryption to false by default. #1885

Closed
wants to merge 3 commits into from

Conversation

pozirk
Copy link
Member

@pozirk pozirk commented Jan 8, 2025

No description provided.

@pozirk pozirk changed the title Bumped Android SDK to 34, Google Play won't accept less. Fixed some typos. Bumped Android SDK to 34, Google Play won't accept lower. Fixed some typos. Jan 8, 2025
@skial skial mentioned this pull request Jan 8, 2025
1 task
@pozirk
Copy link
Member Author

pozirk commented Jan 8, 2025

ios.non-exempt-encryption is set to true by default, so I had to change ITSAppUsesNonExemptEncryption (at {{app.file}}-Info.plist) manually to false, because otherwise Apple would not approve my app.

Set the value for this key to NO in your app’s Information Property List file to indicate that your app—including any third-party libraries you link against—either uses no encryption, or only uses encryption that’s exempt from export compliance requirements, as described in Determine your export compliance requirements. Set the value to YES to indicate that your app uses non-exempt encryption.

From here: https://developer.apple.com/documentation/bundleresources/information-property-list/itsappusesnonexemptencryption

I guess, false by default makes mo sense.

@pozirk pozirk changed the title Bumped Android SDK to 34, Google Play won't accept lower. Fixed some typos. Bumped Android SDK to 34, Google Play won't accept lower. Fixed some typos. Set ios.non-exempt-encryption to false by default. Jan 8, 2025
Copy link

@mcagabe19 mcagabe19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle and gradle plugin version needs to be changed to work with targetSdk 34

@pozirk
Copy link
Member Author

pozirk commented Jan 8, 2025

Hm, I've been manually setting SDK to 34 for some time already, and haven't had any problems with gradle.

@mcagabe19
Copy link

gradle does a warning that complains about target sdk u have to look

@joshtynjala
Copy link
Member

Can you split Android and iOS changes into two separate PRs, please? Thanks!

@pozirk pozirk closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants