Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using Eval to run Lime tools. #1615

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Conversation

player-03
Copy link
Contributor

@player-03 player-03 commented Jan 5, 2023

Similar to #1614, but using a different target. This version leaves Neko as the default, but adds Eval as an option. To enable, pass -eval as an argument.

Pros:

Cons:

  • There's a ~2 second pause every time Eval starts up. (I included a message right before the pause to make it easier to measure.)
  • CFFI is disabled, which might make some features not work. (But do the tools really use audio and fonts and so on?)
  • If someone was already using the -eval flag for their own purposes, this will shadow that. Seems unlikely, given that the usual convention is to use two dashes for any flag longer than a letter.

@player-03
Copy link
Contributor Author

@AdamHarte Give this one a try, see if it fixes your issue.

Plus, do some cleanup. For instance, `nekoOutput` is only used in one
spot, so might as well declare it there.

Aside: I doubt `fullPath()` is needed, but I don't care to test it.
@player-03 player-03 linked an issue Apr 6, 2023 that may be closed by this pull request
@player-03 player-03 merged commit 780ec7e into openfl:8.1.0-Dev Apr 6, 2023
@player-03 player-03 deleted the eval_tools branch April 6, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alloc.c(177) : max_string_size reached
1 participant