Add housing.json file to situation examples; add to README #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Goal -- make it easier for newcomers to the OpenFisca ecosystem to discover examples that use the Enum type within the country template
benjello
approved these changes
Jan 31, 2020
Morendil
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
situation_examplesfolder. The housing example uses theEnumtype; goal is to help newcomers to the OpenFisca world discover this.curlcommand for sending example JSON to local Web API.Changes:
Thanks for considering this pull request!
I opened it after reading @sandcha's reply here — openfisca/openfisca-core#938 (comment) — which made me realize that I didn't fully understand all of the examples provided by this excellent template.
I know it's almost the weekend in Europe (and already the weekend in Asia-Pacific) — enjoy the weekend, no need to review this until next week or whenever there's capacity.