-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reform modifying brackets of a scale #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good comments!
Needs an entry in the README.
from openfisca_core.model_api import * | ||
|
||
|
||
class modify_social_security_brackets(Reform): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This describes what is done, and that's not usually how reforms are named: they usually are named after the law project, or the impact they want to have. These examples are meaningful only if one can rely to it on business cases.
So, here, what would have happened in the modelled country? Refer to the README and add to the story there: maybe this reform was a law proposal made by some representatives as an alternative to the universal basic income?
# We can run this test on our command line using `openfisca-run-test social_security_contribution.yaml` | ||
|
||
# This test is a partial adaptation of `social_security_contribution.yaml` to match the modifications introduced | ||
# by the reform of the same name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we rely on line wrapping on other comments. If that's the case, please be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 😉
|
||
# Note the `reforms: ` key in the below YAML blocks. | ||
|
||
- name: Person earning 2000 in 2013-01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date doesn't match 😉
But I guess that shows the name is bad if it is just a copy of data that is readily available below. What about something like “No social security contribution on small salaries”?
(repeat below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job! 😃
Connected to openfisca/openfisca-france#745
openfisca_country_template/parameters/taxes.xml
These changes: