Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reform modifying brackets of a scale #7

Merged
merged 3 commits into from
May 31, 2017
Merged

Add reform modifying brackets of a scale #7

merged 3 commits into from
May 31, 2017

Conversation

cbenz
Copy link
Member

@cbenz cbenz commented May 24, 2017

Connected to openfisca/openfisca-france#745

  • Tax and benefit system evolution: add a reform modifying the brackets of a scale
  • Impacted periods: from 2013-01-01
  • Impacted areas: openfisca_country_template/parameters/taxes.xml
  • Details:
    • Show how to add, modify and remove a bracket.
    • Add corresponding tests.

These changes:

  • Add a new feature: a reform

@cbenz cbenz requested a review from fpagnoux May 24, 2017 13:59
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good comments!

Needs an entry in the README.

from openfisca_core.model_api import *


class modify_social_security_brackets(Reform):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This describes what is done, and that's not usually how reforms are named: they usually are named after the law project, or the impact they want to have. These examples are meaningful only if one can rely to it on business cases.

So, here, what would have happened in the modelled country? Refer to the README and add to the story there: maybe this reform was a law proposal made by some representatives as an alternative to the universal basic income?

# We can run this test on our command line using `openfisca-run-test social_security_contribution.yaml`

# This test is a partial adaptation of `social_security_contribution.yaml` to match the modifications introduced
# by the reform of the same name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we rely on line wrapping on other comments. If that's the case, please be consistent.

@cbenz cbenz requested a review from MattiSG May 31, 2017 11:28
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😉


# Note the `reforms: ` key in the below YAML blocks.

- name: Person earning 2000 in 2013-01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date doesn't match 😉

But I guess that shows the name is bad if it is just a copy of data that is readily available below. What about something like “No social security contribution on small salaries”?

(repeat below)

@cbenz cbenz requested a review from MattiSG May 31, 2017 20:03
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job! 😃

@cbenz cbenz force-pushed the modify-brackets branch from 5f404f3 to b0ede96 Compare May 31, 2017 20:07
@cbenz cbenz merged commit a56004f into master May 31, 2017
@cbenz cbenz deleted the modify-brackets branch May 31, 2017 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants