Version bump to 2.0.2, added Changelog #60
Conversation
1faac31 to
81462fa
Compare
| element.find_element_by_class_name('input').send_keys(value) | ||
| # Since virtual-dom may be updating DOM elements by replacing them completely, the | ||
| # following method must be used to wait for the input box to appear: | ||
| textbox_visible_selector = '.numerical-input[style*="display: block"] input' |
There was a problem hiding this comment.
@bradenmacdonald Would it be possible to use is_displayed() instead of the style selector?
There was a problem hiding this comment.
@mtyaka I don't think so? I was seeing flaky tests and I think one reason is that if we use this pattern (note wait_until_visible uses is_displayed):
element = find_element_by_class_name('blah')
self.wait_until_visible(element)Then sometimes between the first line and the second line, virtual_dom deletes the element and replaces it with a new one, which then causes this Selenium error: "The element is no longer attached to the DOM."
|
Added a couple of nits, but it looks good 👍 |
81462fa to
a93bd82
Compare
|
@dianakhuang Could you please review this small dndv2 PR as well? It's mostly a version bump so I can tag a new version to update in the edx-platform requirements file and include the fixes you reviewed in #54. I also fixed some flaky tests. (There are no changes to the XBlock code itself in this PR.) |
|
👍 |
Version bump to 2.0.2, added Changelog
This is a version bump so I can tag a new release and get the important fixes from #55 deployed to edx.org.
I also added a changelog and fixed some flaky tests observed while opening this PR.