Fix keyboard help hotkey issues #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dialog, even if page/unit contains multiple DnDv2 exercises.
This fixes two issues related to keyboard help for DnDv2:
- If multiple DnDv2 blocks are on the same page, pressing global
shortcut ("?") brings up multiple dialogs
- It's almost impossible to enter "?" into any of the text boxes in the
block settings in Studio, since it brings up the keyboard help dialog
instead
Not using "?" as a global shortcut for "Keyboard Help" also means that
DnDv2 will not conflict with other XBlocks and/or runtimes that might be
using the same shortcut to, e.g., bring up help dialogs.
4ad5389 to
76dad17
Compare
|
@itsjeyd 👍 |
itsjeyd
added a commit
that referenced
this pull request
Jan 18, 2016
Fix keyboard help hotkey issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bugs affecting user interaction with DnDv2:
?) brings up multiple dialogs.?into any of the text boxes in the block settings in Studio, since it brings up the keyboard help dialog instead.It also extends existing tests for interacting with the "Keyboard Help" dialog:
interact_with_keyboard_helpnow checks if dialog can be dismissed by pressing ESC.MultipleBlocksDataInteractiontest now includes atest_keyboard_helpmethod which verifies that keyboard help works correctly when multiple DnDv2 blocks are present.Test instructions
?into a few different input fields. You should be able to do that without the "Keyboard Help" dialog popping up.