-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajax loader spinner #42
Conversation
right: 0; | ||
top: 0; | ||
margin-right: 5px; | ||
padding-top: 6px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@e-kolpakov Any specific advantage(s) of using padding-top
instead of margin-top
here? (Just asking because I'm curious :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsjeyd the spinner is shown as if it is inside the text input, so it's just for the symmetry: both spinner wrapper and text input have the same padding.
@e-kolpakov The spinners work well, and aside from the things I pointed out above the code LGTM as well. I like the idea of showing spinners right where users would be focusing their attention when dropping an item or submitting an additional answer! The only aspect I'm not entirely convinced about is how they behave for items that contain images instead of text -- it looks a bit weird to have the spinner displayed above the image. Do you think it would be possible to display the spinner on top of the image instead (sort of like an overlay)? |
@e-kolpakov Instead of calling
In fact, we already have |
@e-kolpakov Looking great, thanks for the additional changes! 👍 from me once you remove that leftover comment. But since I don't know virtualdom that well, I'll let @mtyaka give the final go-ahead for merging. |
87116ea
to
0e72330
Compare
@e-kolpakov Thanks for the changes, they look good! 👍 once you get the test passing. |
Description: this PR adds loader spinners to elements that trigger ajax request.
Testing instructions: