Add ability to ask for numerical value on drop. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the input value (with optional margin) is set for a drop item, an input field is shown and focused when the user drops the item on the correct zone. The value is submitted on field blur. If correct (within the margin), the field is colored green. If the value is not correct, the field is colored red. In either case, the field gets disabled and user cannot try again until resetting the exercise. The exercise is not considered finished until all required input fields are filled. If the item has an input set, the user only gets points for the item if the input value is within the correct margin. The patch includes changes to the testing infrastructure. Instead of having to checkout the `xblock-sdk` repository and set `xblock-drag-and-drop-v2` to run within it, the `xblock-sdk` repository has been added to the test requirements. A barebone django app that loads the workbench to run integration tests has been created inside the tests folder. All test dependencies have been explicitly pinned in `test/requirements.txt`. Assuming you have Firefox installed, running the tests should be as simple as `pip install -r tests/requirements.txt` in a fresh virtual environment and then `tests/manage.py test`.
|
👍 Also reviewed by @Kelketek in open-craft#1 - merging. |
antoviaque
added a commit
that referenced
this pull request
Dec 4, 2014
Add ability to ask for numerical value on drop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the input value (with optional margin) is set for a drop item,
an input field is shown and focused when the user drops the item
on the correct zone.
The value is submitted on field blur. If correct (within the margin),
the field is colored green. If the value is not correct, the field is
colored red. In either case, the field gets disabled and user cannot
try again until resetting the exercise.
The exercise is not considered finished until all required input
fields are filled.
If the item has an input set, the user only gets points for the item if
the input value is within the correct margin.