Add touch device support #21
Conversation
| 'public/js/drag_and_drop.js', | ||
| ) | ||
| for css_url in CSS_URLS: | ||
| fragment.add_css_url(self.runtime.local_resource_url(self, css_url)) |
There was a problem hiding this comment.
self.runtime.local_resource_url appends settings.SITE_NAME from lms configuration to resource url. Devstack have SITE_NAME set to localhost:8000, which obviously does not work when trying to access lms from mobile device. It shouldn't be a problem in production, since SITE_NAME should point to lms domain name anyway, but it could make sense to either:
- Use some other way of appending resources: namely, anyone that results in relative links for resources (I'm not yet aware of any, @antoviaque, @dragonfi, @aboudreault or @mtyaka to the rescue :))
- Assemble some manual on making it available for external devices (in my case it was just setting
SITE_NAMEto IP of the computer running lms)
There was a problem hiding this comment.
I tried option 2 - I mentioned this in this PR description ;)
There was a problem hiding this comment.
@bradenmacdonald yes, I've seen that, I was about to say it could be helpful in future to have this bit of information in documentation somewhere.
There was a problem hiding this comment.
@e-kolpakov +1 - that can be helpful to add to the newcomer documentation, feel free to send a PR there, they are always appreciated and useful : )
|
Nice short fix btw! 👍 |
…handling When dragging, scroll target image as needed
This adds touch support, because the dragging and dropping was not working on mobile devices. Uses jQuery UI Touch Punch to make this work.
I've tested and confirmed it works in:
Note: in order to connect to the devstack from an iPad, I had to modify
lms/envs/devstack.pyon the computer and setSITE_NAME = '192.168.1.xx:8000'rather thanSITE_NAME = 'localhost:8000'- otherwise the XBlock wasn't loading correctly.