-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove python < 3.11 references and Tutor < 18 #1014
Conversation
@@ -3,6 +3,6 @@ bcrypt | |||
importlib-resources | |||
openedx-atlas | |||
transifex-python | |||
tutor>=15 | |||
tutor>=18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a no-op since the rest of the requirements are already at 19.1
tutoraspects/patches/openedx-dev-dockerfile-post-python-requirements
Outdated
Show resolved
Hide resolved
@@ -13,7 +13,6 @@ | |||
from tutor import hooks | |||
|
|||
from .__about__ import __version__ | |||
from .commands_v0 import COMMANDS as TUTOR_V0_COMMANDS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0 commands were from earlier (pre-Palm?) versions or Tutor which we no longer support
These are requirements files that go in the Aspects and Aspects-Superset images.
This version of PPA contains the changes that drop Python 3.8 compatibility.
35855b7
to
7581666
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works for me too :)
- I tested this by re-deploying my Tutor aspects dev stack, and checking that data continues to flow through to Aspects/Superset as expected.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A
Closes #935
Closes #1013
These are our first round of breaking changes for Aspects 2.0 - the rest of the Python 3.8 removal and dropping support for Open edX Nutmeg, Olive, and Palm (which all required Python 3.8).