Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove python < 3.11 references and Tutor < 18 #1014

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Jan 24, 2025

Closes #935
Closes #1013

These are our first round of breaking changes for Aspects 2.0 - the rest of the Python 3.8 removal and dropping support for Open edX Nutmeg, Olive, and Palm (which all required Python 3.8).

@bmtcril bmtcril marked this pull request as draft January 24, 2025 18:47
@@ -3,6 +3,6 @@ bcrypt
importlib-resources
openedx-atlas
transifex-python
tutor>=15
tutor>=18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a no-op since the rest of the requirements are already at 19.1

@@ -13,7 +13,6 @@
from tutor import hooks

from .__about__ import __version__
from .commands_v0 import COMMANDS as TUTOR_V0_COMMANDS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0 commands were from earlier (pre-Palm?) versions or Tutor which we no longer support

These are requirements files that go in the Aspects and Aspects-Superset
images.
This version of PPA contains the changes that drop Python 3.8
compatibility.
@bmtcril bmtcril force-pushed the bmtcril/drop_py_38 branch from 35855b7 to 7581666 Compare January 28, 2025 18:16
@bmtcril bmtcril marked this pull request as ready for review January 28, 2025 19:52
Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works for me too :)

  • I tested this by re-deploying my Tutor aspects dev stack, and checking that data continues to flow through to Aspects/Superset as expected.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A

@bmtcril bmtcril requested a review from Yagnesh1998 January 30, 2025 14:21
@bmtcril bmtcril merged commit a7aaa87 into main Jan 30, 2025
9 checks passed
@bmtcril bmtcril deleted the bmtcril/drop_py_38 branch January 30, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Refresh dependencies Drop support for Python 3.8
3 participants