[BD-46] refactor: corrected PropTypes #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
24fa73d to
97355d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2960 +/- ##
=======================================
Coverage 92.99% 93.00%
=======================================
Files 235 236 +1
Lines 4268 4273 +5
Branches 1033 1033
=======================================
+ Hits 3969 3974 +5
Misses 295 295
Partials 4 4 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
approved these changes
Dec 22, 2023
| @@ -38,7 +38,7 @@ This component is used to power Tooltips and Popovers. | |||
| Click me to see | |||
| </Button> | |||
| </div> | |||
| <Overlay target={target.current} show={open} placement="right"> | |||
| <Overlay target={target.current} show={isOpen} placement="right"> | |||
97355d2 to
c4d318f
Compare
|
🎉 This PR is included in version 21.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 22.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: #2737
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist