-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove ~ from import of react-loading-skeleton #2912
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2912 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 215 215
Lines 3643 3643
Branches 901 901
=======================================
Hits 3399 3399
Misses 239 239
Partials 5 5 ☔ View full report in Codecov by Sentry. |
[inform] Opting to merge this PR to unblock progress on this We can come back to update the inclusion of the |
🎉 This PR is included in version 22.0.0-alpha.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Since #2858 added the import of
react-loading-skeleton
's stylesheet to the core.scss file, the core stylesheet has seemingly been failing to build (i.e.,@import "~react-loading-skeleton/dist/skeleton.css";
):Removing the
~
resolves the issue in the build command and Skeleton styles still appear on the docs site. I have not verified theSkeleton
styles on a consuming MFE runningalpha
yet.It also ensures
core
is included in this output oftheme-urls.json
, resolving a bug in openedx/frontend-build#365:Deploy Preview
https://deploy-preview-2912--paragon-openedx.netlify.app/components/skeleton/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist