Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ~ from import of react-loading-skeleton #2912

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Dec 9, 2023

Description

Since #2858 added the import of react-loading-skeleton's stylesheet to the core.scss file, the core stylesheet has seemingly been failing to build (i.e., @import "~react-loading-skeleton/dist/skeleton.css";):

image

Removing the ~ resolves the issue in the build command and Skeleton styles still appear on the docs site. I have not verified the Skeleton styles on a consuming MFE running alpha yet.

It also ensures core is included in this output of theme-urls.json, resolving a bug in openedx/frontend-build#365:

{
  "themeUrls": {
    "defaults": {
      "light": "light"
    },
    "variants": {
      "light": {
        "paths": {
          "default": "./light.css",
          "minified": "./light.min.css"
        }
      }
    },
    "core": {
      "paths": {
        "default": "./core.css",
        "minified": "./core.min.css"
      }
    }
  }
}

Deploy Preview

https://deploy-preview-2912--paragon-openedx.netlify.app/components/skeleton/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit d96f9d8
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6574d2bc31b3c40008fadbdc
😎 Deploy Preview https://deploy-preview-2912--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (c20b213) to head (d96f9d8).
Report is 506 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #2912   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         215      215           
  Lines        3643     3643           
  Branches      901      901           
=======================================
  Hits         3399     3399           
  Misses        239      239           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz
Copy link
Member Author

[inform] Opting to merge this PR to unblock progress on this frontend-build PR. The depicted build error with the core stylesheet prevents the core property from being added to the generated theme-urls.json file during npm run build.

We can come back to update the inclusion of the ~ if this fix blocks skeleton styles from loading for consuming MFEs.

@adamstankiewicz adamstankiewicz merged commit eb6b293 into alpha Dec 10, 2023
@adamstankiewicz adamstankiewicz deleted the ags/resolve-core-scss-not-building branch December 10, 2023 15:26
@openedx-semantic-release-bot

🎉 This PR is included in version 22.0.0-alpha.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants