-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: fixed incorrect label in Select All button #2020
[BD-46] fix: fixed incorrect label in Select All button #2020
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
162a721
to
8b8d75a
Compare
Codecov ReportBase: 90.82% // Head: 90.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2020 +/- ##
=======================================
Coverage 90.82% 90.82%
=======================================
Files 233 233
Lines 4099 4100 +1
Branches 971 972 +1
=======================================
+ Hits 3723 3724 +1
Misses 369 369
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8b8d75a
to
2f8d210
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good :) Should we also update tests for SelectionStatus
to account for the new logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good :) Should we also update tests for SelectionStatus
to account for the new logic?
4132753
to
121680d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix!
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 20.30.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 21.0.0-alpha.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Issue: #1837
Deploy Preview
Data Table
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist