Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: fixed incorrect label in Select All button #2020

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Feb 14, 2023

Description

  • "Select all" button has "Select all 7" label even though there are only 2 rows displayed after applying filters

image

Issue: #1837

Deploy Preview

Data Table

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Feb 14, 2023
@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 121680d
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/63f502c3d7669a0008cacb9a
😎 Deploy Preview https://deploy-preview-2020--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 90.82% // Head: 90.82% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4132753) compared to base (a0f1761).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4132753 differs from pull request most recent head 121680d. Consider uploading reports for the commit 121680d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2020   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files         233      233           
  Lines        4099     4100    +1     
  Branches      971      972    +1     
=======================================
+ Hits         3723     3724    +1     
  Misses        369      369           
  Partials        7        7           
Impacted Files Coverage Δ
src/DataTable/selection/BaseSelectionStatus.jsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fix-incorrect-label-in-Select-all-btn branch from 8b8d75a to 2f8d210 Compare February 14, 2023 16:07
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good :) Should we also update tests for SelectionStatus to account for the new logic?

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good :) Should we also update tests for SelectionStatus to account for the new logic?

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/fix-incorrect-label-in-Select-all-btn branch from 4132753 to 121680d Compare February 21, 2023 17:43
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@adamstankiewicz adamstankiewicz merged commit e2f6727 into openedx:master Apr 21, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.30.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.0.0-alpha.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

'Select all' button has incorrect label with applied filters in DataTable
4 participants