Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: replace of variables SCSS to CSS #1633

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Sep 19, 2022

Description

  • implement design tokens for primitive SCSS variables in each component
  • refactor component SCSS styles to use new CSS variables with minimal breaking changes (use tokens/replace-variables.js script).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Sep 19, 2022
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/replace-of-variables-SCSS-to-CSS branch from ef26f0b to be6ac06 Compare September 22, 2022 11:57
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/replace-of-variables-SCSS-to-CSS branch from 46f6c7f to adef627 Compare September 23, 2022 10:01
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feat/design-tokens@1f0749d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/design-tokens    #1633   +/-   ##
=====================================================
  Coverage                      ?   91.57%           
=====================================================
  Files                         ?      208           
  Lines                         ?     3537           
  Branches                      ?      821           
=====================================================
  Hits                          ?     3239           
  Misses                        ?      283           
  Partials                      ?       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/replace-of-variables-SCSS-to-CSS branch from b29267f to 64e95c0 Compare September 28, 2022 10:50
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/replace-of-variables-SCSS-to-CSS branch from d65cb3d to 84a5aa2 Compare September 29, 2022 22:08
@viktorrusakov viktorrusakov merged commit fb90e45 into openedx:feat/design-tokens Sep 30, 2022
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] DRAFT: replace of variables SCSS to CSS [BD-46] feat: replace of variables SCSS to CSS Oct 3, 2022
viktorrusakov pushed a commit that referenced this pull request Nov 1, 2022
* feat: replace SCSS variables to CSS

Co-authored-by: vzadorozhnii <vladyslav.zadorozhnii@raccoongang.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants