Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add broader range of exceptions for filters to use #26

Merged
merged 1 commit into from
Apr 1, 2022
Merged

feat: add broader range of exceptions for filters to use #26

merged 1 commit into from
Apr 1, 2022

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Feb 24, 2022 •
edited
Loading

Description:

This PR adds new exceptions for filters that interact with edxapp templates, allowing to:

  1. Redirections when raising
  2. Render a new template when failing

Testing instructions:

Use these PRs and follow their testing instructions.

Reviewers:

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Commits are squashed

Post merge:

  • Create a tag
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/template-exceptions branch from 982320b to 4121566 Compare March 30, 2022 20:41
@felipemontoya
Copy link
Member

I tested this branch of the filters definitions on the filters defined by openedx/edx-platform#29996 and openedx/edx-platform#29995 and they worked correctly.

I think we are good to merge this once tests pass.

@mariajgrimaldi mariajgrimaldi mentioned this pull request Apr 1, 2022
Merged
5 tasks
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/template-exceptions branch 6 times, most recently from b98ab73 to 18683a3 Compare April 1, 2022 19:31
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/template-exceptions branch from 18683a3 to b50d837 Compare April 1, 2022 19:38
@mariajgrimaldi mariajgrimaldi merged commit b79dc10 into main Apr 1, 2022
@mariajgrimaldi mariajgrimaldi deleted the MJG/template-exceptions branch August 31, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipemontoya felipemontoya felipemontoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariajgrimaldi @felipemontoya