Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add python 3.12 support #458

Merged
merged 11 commits into from
Feb 13, 2025

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Feb 6, 2025

Description

This PR adds support to Python 3.12

Supporting information

Checklists

Check off if complete or not applicable:

Merge Checklist:

  • All reviewers approved
  • Reviewer tested the code following the testing instructions
  • CI build is green
  • Version bumped
  • Changelog record added with short description of the change and current date
  • Documentation updated (not only docstrings)
  • Code dependencies reviewed
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post Merge:

  • Create a tag
  • Create a release on GitHub
  • Check new version is pushed to PyPI after tag-triggered build is
    finished.
  • Delete working branch (if not needed anymore)
  • Upgrade the package in the Open edX platform requirements (if applicable)

@openedx-webhooks
Copy link

openedx-webhooks commented Feb 6, 2025

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/hooks-extension-framework.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 6, 2025
@BryanttV BryanttV force-pushed the bav/python3.12-support branch 2 times, most recently from bbc073d to 2346bd9 Compare February 11, 2025 19:37
@BryanttV BryanttV marked this pull request as ready for review February 11, 2025 20:05
@BryanttV BryanttV requested a review from a team as a code owner February 11, 2025 20:05
@mariajgrimaldi mariajgrimaldi linked an issue Feb 12, 2025 that may be closed by this pull request
.github/workflows/ci.yml Outdated Show resolved Hide resolved
requirements/constraints.txt Show resolved Hide resolved
@BryanttV BryanttV force-pushed the bav/python3.12-support branch from 32f5696 to 26b55fe Compare February 12, 2025 13:50
@mariajgrimaldi
Copy link
Member

What do you think about this being a chore instead, given that we're mainly adding additional checks for maintenance?

@BryanttV BryanttV changed the title feat: add python 3.12 support chore: add python 3.12 support Feb 13, 2025
@BryanttV BryanttV force-pushed the bav/python3.12-support branch from 6d4aaa3 to 3367ba3 Compare February 13, 2025 13:30
@BryanttV
Copy link
Contributor Author

Hi @mariajgrimaldi, yes, chore is better in this case. I updated the title.

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing all of my comments. Can you update the changelog and the __init__ file considering the chore change?

@mariajgrimaldi mariajgrimaldi merged commit b811a5d into openedx:main Feb 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Astroid CI RecursionError: maximum recursion depth exceeded
3 participants