Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: used node 18 to fix release workflow which has latest semantic release #431

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

abdullahwaheed
Copy link
Contributor

Description:

Used node 18 in release workflow which was breaking due to latest semantic release which has node 18 dependency.
Tested npm ci, npm run build and npm run docs locally

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@abdullahwaheed abdullahwaheed requested a review from a team January 25, 2023 10:09
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 81.51% // Head: 81.51% // No change to project coverage 👍

Coverage data is based on head (4867484) compared to base (f90d4af).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   81.51%   81.51%           
=======================================
  Files          38       38           
  Lines         925      925           
  Branches      169      169           
=======================================
  Hits          754      754           
  Misses        159      159           
  Partials       12       12           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@abdullahwaheed abdullahwaheed merged commit d67bc01 into master Jan 25, 2023
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/release-workflow-node-update branch January 25, 2023 10:13
@arbrandes
Copy link
Contributor

@abdullahwaheed, what is the impact of this on consumers of frontend-platform that do not yet support Node 18 explicitly?

@abdullahwaheed
Copy link
Contributor Author

@arbrandes we have just used node 18 in release workflow as newer version of semantic release dependent on node 18. It won't impact consumers as every consumer, which is a library, has its own release workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants