refactor: Updated frontend-build to v12 (#270)

* refactor: updated frontend-build to v12 & resolved eslint issues
openedx · Jan 24, 2023 · 5f7e948 · 5f7e948
1 parent cb25fee
commit 5f7e948
Show file tree

Hide file tree

Showing 18 changed files with 1,552 additions and 1,609 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/catalog-search/.eslintrc.js b/packages/catalog-search/.eslintrc.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 const { createConfig } = require('@edx/frontend-build');
 const extendESLintConfig = require('../../common/extendESLintConfig');
 

diff --git a/packages/catalog-search/package.json b/packages/catalog-search/package.json
@@ -44,7 +44,7 @@
   },
   "devDependencies": {
     "@edx/browserslist-config": "1.1.0",
-    "@edx/frontend-build": "11.0.1",
+    "@edx/frontend-build": "12.3.0",
     "@edx/frontend-platform": "1.15.6",
     "@edx/paragon": "19.25.1",
     "@fortawesome/free-solid-svg-icons": "5.8.1",

diff --git a/packages/catalog-search/src/SearchSuggestionItem.jsx b/packages/catalog-search/src/SearchSuggestionItem.jsx
@@ -45,7 +45,6 @@ SearchSuggestionItem.propTypes = {
     key: PropTypes.string,
     title: PropTypes.string,
     program_type: PropTypes.string,
-    authoring_organizations: PropTypes.array,
     _highlightResult: PropTypes.shape({ title: PropTypes.shape({ value: PropTypes.string }) }),
   }).isRequired,
   disableSuggestionRedirect: PropTypes.bool.isRequired,

diff --git a/packages/catalog-search/src/SearchSuggestions.jsx b/packages/catalog-search/src/SearchSuggestions.jsx
@@ -60,7 +60,9 @@ const SearchSuggestions = ({
 };
 
 SearchSuggestions.propTypes = {
-  autoCompleteHits: PropTypes.arrayOf(PropTypes.object).isRequired,
+  autoCompleteHits: PropTypes.arrayOf(PropTypes.shape({
+    content_type: PropTypes.string,
+  })).isRequired,
   enterpriseSlug: PropTypes.string,
   handleSubmit: PropTypes.func,
   handleSuggestionClickSubmit: PropTypes.func,

diff --git a/packages/catalog-search/src/data/reducer.js b/packages/catalog-search/src/data/reducer.js
@@ -6,7 +6,7 @@ import {
 } from './actions';
 import { QUERY_PARAMS_TO_IGNORE } from './constants';
 
-export const refinementsReducer = (state = {}, action) => {
+export const refinementsReducer = (state = {}, action = {}) => {
   const nextState = { ...state };
   switch (action.type) {
     case DELETE_REFINEMENT:

diff --git a/packages/catalog-search/src/tests/FacetListBase.test.jsx b/packages/catalog-search/src/tests/FacetListBase.test.jsx
@@ -179,7 +179,7 @@ describe('<FacetListBase />', () => {
       fireEvent.change(screen.queryByPlaceholderText('Find a skill...'), { target: { value: 'Blockchain' } });
     });
 
-    await new Promise((r) => setTimeout(r, 210));
+    await new Promise((r) => { setTimeout(r, 210); });
 
     expect(searchableDropdownProps.searchForItems).toHaveBeenCalledTimes(1);
     expect(searchableDropdownProps.searchForItems).toHaveBeenCalledWith('Blockchain');

diff --git a/packages/catalog-search/src/tests/SearchFilters.test.jsx b/packages/catalog-search/src/tests/SearchFilters.test.jsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { useMemo } from 'react';
 import { screen } from '@testing-library/react';
 import '@testing-library/jest-dom/extend-expect';
 import { breakpoints, ResponsiveContext } from '@edx/paragon';
@@ -9,13 +9,18 @@ import { renderWithSearchContext } from './utils';
 import '../../__mocks__/react-instantsearch-dom';
 import SearchFilters from '../SearchFilters';
 
+const SearchContextWrapper = () => {
+  const contextValue = useMemo(() => ({ width: breakpoints.large.maxWidth }), []);
+  return (
+    <ResponsiveContext.Provider value={contextValue}>
+      <SearchFilters />
+    </ResponsiveContext.Provider>
+  );
+};
+
 describe('<SearchFilters />', () => {
   test('renders with a label', () => {
-    renderWithSearchContext(
-      <ResponsiveContext.Provider value={{ width: breakpoints.large.maxWidth }}>
-        <SearchFilters />
-      </ResponsiveContext.Provider>,
-    );
+    renderWithSearchContext(<SearchContextWrapper />);
     SEARCH_FACET_FILTERS.forEach((filter) => {
       expect(screen.getByText(filter.title)).toBeInTheDocument();
     });

diff --git a/packages/catalog-search/src/tests/SearchPagination.test.jsx b/packages/catalog-search/src/tests/SearchPagination.test.jsx
@@ -32,13 +32,12 @@ describe('<SearchPagination />', () => {
     expect(history.location.search).toEqual('');
   });
   test('updates page query when navigating left to a previous page', () => {
-    const { history } = renderWithRouter(
+    const { history } = renderWithRouter((
       <SearchData>
         <SearchPaginationBase nbPages={4} currentRefinement={3} />
-      </SearchData>, {
-        route: 'search/?page=3',
-      },
-    );
+      </SearchData>), {
+      route: 'search/?page=3',
+    });
 
     // assert SearchData adds showAll
     expect(history.location.search).toEqual('?page=3');

diff --git a/packages/hotjar/.eslintrc.js b/packages/hotjar/.eslintrc.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 const { createConfig } = require('@edx/frontend-build');
 const extendESLintConfig = require('../../common/extendESLintConfig');
 

diff --git a/packages/hotjar/package.json b/packages/hotjar/package.json
@@ -38,7 +38,7 @@
   "sideEffects": false,
   "devDependencies": {
     "@edx/browserslist-config": "1.1.0",
-    "@edx/frontend-build": "11.0.1",
+    "@edx/frontend-build": "12.3.0",
     "react": "16.14.0",
     "react-dom": "16.14.0",
     "react-router-dom": "5.2.0"

diff --git a/packages/logistration/.eslintrc.js b/packages/logistration/.eslintrc.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 const { createConfig } = require('@edx/frontend-build');
 const extendESLintConfig = require('../../common/extendESLintConfig');
 

diff --git a/packages/logistration/package.json b/packages/logistration/package.json
@@ -42,7 +42,7 @@
   },
   "devDependencies": {
     "@edx/browserslist-config": "1.1.0",
-    "@edx/frontend-build": "11.0.1",
+    "@edx/frontend-build": "12.3.0",
     "@edx/frontend-platform": "1.15.6",
     "@testing-library/jest-dom": "5.11.6",
     "@testing-library/react": "11.2.6",

diff --git a/packages/logistration/src/LoginRedirect.jsx b/packages/logistration/src/LoginRedirect.jsx
@@ -12,7 +12,7 @@ import { getProxyLoginUrl } from './utils';
  * @param {node} children The child nodes to render if there is an authenticated user.
  * @param {element} loadingDisplay A React element to display while authenticated user is loading
  */
-export default function LoginRedirect({ children, loadingDisplay: LoadingDisplay }) {
+const LoginRedirect = ({ children, loadingDisplay: LoadingDisplay }) => {
   const {
     enterpriseSlug,
     enterpriseCustomerInviteKey,
@@ -27,7 +27,7 @@ export default function LoginRedirect({ children, loadingDisplay: LoadingDisplay
   global.location.href = getProxyLoginUrl(enterpriseSlug, enterpriseCustomerInviteKey);
 
   return LoadingDisplay;
-}
+};
 
 LoginRedirect.propTypes = {
   children: PropTypes.node,
@@ -38,3 +38,5 @@ LoginRedirect.defaultProps = {
   children: null,
   loadingDisplay: null,
 };
+
+export default LoginRedirect;
diff --git a/packages/utils/.eslintrc.js b/packages/utils/.eslintrc.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
 const { createConfig } = require('@edx/frontend-build');
 const extendESLintConfig = require('../../common/extendESLintConfig');
 

diff --git a/packages/utils/package.json b/packages/utils/package.json
@@ -42,7 +42,7 @@
   },
   "devDependencies": {
     "@edx/browserslist-config": "1.1.0",
-    "@edx/frontend-build": "11.0.1",
+    "@edx/frontend-build": "12.3.0",
     "@edx/frontend-platform": "1.15.6",
     "react": "16.14.0",
     "react-dom": "16.14.0",

diff --git a/packages/utils/src/analytics.js b/packages/utils/src/analytics.js
@@ -28,5 +28,5 @@ export const sendEnterpriseTrackEventWithDelay = (
     eventName,
     properties,
   );
-  return new Promise((resolve) => setTimeout(resolve, delay));
+  return new Promise((resolve) => { setTimeout(resolve, delay); });
 };
diff --git a/packages/utils/src/test-utils.jsx b/packages/utils/src/test-utils.jsx
@@ -12,9 +12,7 @@ export const renderWithRouter = (
   } = {},
 ) => {
   // eslint-disable-next-line react/prop-types
-  const Wrapper = ({ children }) => (
-    <Router history={history}>{children}</Router>
-  );
+  const Wrapper = ({ children }) => <Router history={history}>{children}</Router>;
   return {
     ...render(ui, { wrapper: Wrapper }),
     // adding `history` to the returned utilities to allow us