Enable support for React 18 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec19ce1 to
d973bf1
Compare
d973bf1 to
fa7306f
Compare
This was referenced Feb 11, 2025
0954148 to
599dc60
Compare
599dc60 to
4350d61
Compare
|
The sandbox for openedx/frontend-app-authoring#1675 is up and everything I've tested is looking good! https://app.pr-1675-e8373e.sandboxes.opencraft.hosting/authoring/course/course-v1:demo+Course+1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #625 +/- ##
=============================
=============================
☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 14.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 15.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Open edX MFEs are overdue to support React 18 (especially as React 19 is already out now, too). Some efforts have been started to support React 18 in the shared JavaScript libraries, such as Paragon (openedx/paragon#3367, v22 and v23).
By enabling support for React 18 (should be additive-only), we can further enable incremental migration to React 18 within MFEs. Most of the changes are within the example MFE included in this repository for testing.
The React 18 Upgrade Guide was followed.
Additionally:
@svgr/webpackis also run on.tsxfiles.react-test-rendererin favor of@testing-library/reactwithin the example MFE app.reduxandreact-reduxpeer dependencies optional, as some MFEs opt to not use Redux in favor of React Query.