Upgraded frontend-build version to v12 #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
requested changes
Jul 19, 2022
There was a problem hiding this comment.
I am currently working on upgrading this repo to @edx/frontend-build v11, and addressing all the eslint errors around hooks (there are many).
Note: the v12 version of @edx/frontend-build is passing eslint even though there are many actual eslint errors, so the passing CI on this PR is a red herring. I will file a separate Github issue in frontend-wg shortly with more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
42: Upgrade eslint to v8.x
What changed?
frontend-buildto v12 (Eslint was updated infrontend-buildversion resulting in it's version being bumped to v12. This PR updatesfrontend-buildto reciprocate eslint version update)