build: reinstall node_modules with npm 6 since we're not yet on npm 7 as an organization #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as an organization
long74100
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit had installed
node_modulesusing Node 14 and NPM 7. This caused the package-lock.json file to uselockfileVersion: 2and means any time someone next installsnode_modulesusing NPM 6, the package-lock.json file would revert back to usinglockfileVersion: 1, as it does in this PR.Our micro-frontends across the organization are still using Node 12 and NPM 6, so this PR handles that switch back to
lockfileVersion: 1as to not cause surprises why there are 25,000+ line changes in package-lock.json in future PRs even when no new packages are installed.FWIW, the Frontend Working Group is currently gearing up to upgrade all our frontends to use Node 16 and NPM 7 as described in this issue, but until then we should stay using Node 12 and NPM 6.