Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lk/use share browserlist #299

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Lk/use share browserlist #299

merged 4 commits into from
Jan 5, 2023

Conversation

leangseu-edx
Copy link
Contributor

TL;DR -

@leangseu-edx leangseu-edx requested a review from a team as a code owner January 5, 2023 15:37
@leangseu-edx leangseu-edx force-pushed the lk/use-share-browserlist branch from 21ee9e8 to 8d7d448 Compare January 5, 2023 15:38
@leangseu-edx leangseu-edx force-pushed the lk/use-share-browserlist branch from 8d7d448 to 5de8c08 Compare January 5, 2023 15:40
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5de8c08) compared to base (ecceda2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #299   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         1263      1260    -3     
  Branches       248       248           
=========================================
- Hits          1263      1260    -3     
Impacted Files Coverage Δ
src/components/GradesView/EditModal/index.jsx 100.00% <ø> (ø)
src/components/GradesView/GradebookTable/index.jsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nsprenkle nsprenkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and fixes the issue for me locally :shipit:

@leangseu-edx leangseu-edx merged commit 011737b into master Jan 5, 2023
@leangseu-edx leangseu-edx deleted the lk/use-share-browserlist branch January 5, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants