-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace hardcoded logo with logo from configs #426
feat: replace hardcoded logo with logo from configs #426
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportBase: 74.26% // Head: 74.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 106 106
Lines 2067 2067
Branches 512 512
=======================================
Hits 1535 1535
Misses 504 504
Partials 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hi @ihor-romaniuk! Is this PR ready for review/merge? |
Hi @ihor-romaniuk - is this pull request ready for merge? CC: @arbrandes |
Hi @arbrandes - flagging this as I think it's ready-to-go. |
@mphilbrick211 Sorry for delay. It's ready for merge. |
Hi @arbrandes and @jristau1984! Flagging this for your review / merge. Thanks! |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
The current implementation of the header component is custom and doesn't use
frontend-component-header
as it works in all MFEs so we can't make any changes without interfering with the MFE code.This PR provides the ability to change the header logo via MFE configuration instead of a hardcoded logo.
Related PRs:
PR to the olive brunch - #423