Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [RTL]: mirror legacy page card arrow #358

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ARMBouhali
Copy link
Contributor

@ARMBouhali ARMBouhali commented Oct 6, 2022

TL;DR - fixes a forward arrow in pages & resources > page card that wasn't mirrored for RTL.

Details

  • the mirroring is done within the PageCard.scss file where a transform: scaleX(-1) CSS property is used on an RTL selector. It's much cleaner and lighter than editing JS code.

Screenshots
The forward arrow button should follow text direction

LTR for reference RTL before fix RTL after fix
image Screenshot from 2022-10-06 10-10-58 Screenshot from 2022-10-06 10-10-23

@openedx-webhooks
Copy link

Thanks for the pull request, @ARMBouhali! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 72.99% // Head: 72.99% // No change to project coverage 👍

Coverage data is based on head (5316bbe) compared to base (748aee2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   72.99%   72.99%           
=======================================
  Files         106      106           
  Lines        2037     2037           
  Branches      496      496           
=======================================
  Hits         1487     1487           
  Misses        522      522           
  Partials       28       28           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mphilbrick211
Copy link

Hi @ARMBouhali - is this ready for review / approval for testing?

@ARMBouhali ARMBouhali force-pushed the fix-rtl-pagecard-arrow branch 2 times, most recently from 4c58cb5 to 92c7366 Compare October 14, 2022 15:28
@ARMBouhali ARMBouhali changed the title fix [RTL]: mirror legacy page card arrow Fix [RTL]: mirror legacy page card arrow Oct 14, 2022
@ARMBouhali ARMBouhali force-pushed the fix-rtl-pagecard-arrow branch from 92c7366 to fc0e483 Compare October 23, 2022 17:24
@ARMBouhali
Copy link
Contributor Author

@mphilbrick211 Now it's ready after I switched to CSS-only changes.
Can you please authorize the checks?

@ARMBouhali ARMBouhali force-pushed the fix-rtl-pagecard-arrow branch from fc0e483 to 5316bbe Compare October 24, 2022 11:42
@mphilbrick211
Copy link

@jristau1984 could you please review and authorize tests to run?

@mphilbrick211
Copy link

mphilbrick211 commented Oct 28, 2022

@jristau1984 could you please review and authorize tests to run?

Friendly ping on this @jristau1984. Also tagging @brian-smith-tcril in case he can help authorize the tests as well.

@mphilbrick211
Copy link

@brian-smith-tcril - Jeremy is out of the office, would you mind reviewing and allowing tests to run?

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arbrandes arbrandes merged commit 34fe291 into openedx:master Nov 7, 2022
@openedx-webhooks
Copy link

@ARMBouhali 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ARMBouhali ARMBouhali deleted the fix-rtl-pagecard-arrow branch November 8, 2022 09:27
rpenido pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Jan 2, 2024
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants