-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix [RTL]: mirror legacy page card arrow #358
Conversation
Thanks for the pull request, @ARMBouhali! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportBase: 72.99% // Head: 72.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 72.99% 72.99%
=======================================
Files 106 106
Lines 2037 2037
Branches 496 496
=======================================
Hits 1487 1487
Misses 522 522
Partials 28 28 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi @ARMBouhali - is this ready for review / approval for testing? |
4c58cb5
to
92c7366
Compare
92c7366
to
fc0e483
Compare
@mphilbrick211 Now it's ready after I switched to CSS-only changes. |
fc0e483
to
5316bbe
Compare
@jristau1984 could you please review and authorize tests to run? |
Friendly ping on this @jristau1984. Also tagging @brian-smith-tcril in case he can help authorize the tests as well. |
@brian-smith-tcril - Jeremy is out of the office, would you mind reviewing and allowing tests to run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@ARMBouhali 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
TL;DR - fixes a forward arrow in pages & resources > page card that wasn't mirrored for RTL.
Details
transform: scaleX(-1)
CSS property is used on an RTL selector. It's much cleaner and lighter than editing JS code.Screenshots
The forward arrow button should follow text direction