Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Height in Advanced Editor [FC-0076] #1649

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −3
Open

fix: Height in Advanced Editor [FC-0076] #1649

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
660d35f
fix: Height in Advanced Editor
ChrisChV Feb 4, 2025
bfc12d1
style: Nits on the code
ChrisChV Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/library-authoring/LibraryBlock/LibraryBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ export const LibraryBlock = ({
view,
}: LibraryBlockProps) => {
const iframeRef = useRef<HTMLIFrameElement>(null);
const [iFrameHeight, setIFrameHeight] = useState(50);
const defaultiFrameHeight = view === 'studio_view' ? 80 : 50;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this would be clearer if you moved the line from below up here and used its value:

Suggested change
const defaultiFrameHeight = view === 'studio_view' ? 80 : 50;
const xblockView = view ?? 'student_view';
const defaultiFrameHeight = xblockView === 'studio_view' ? 80 : 50;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bfc12d1


const [iFrameHeight, setIFrameHeight] = useState(defaultiFrameHeight);
const studioBaseUrl = getConfig().STUDIO_BASE_URL;

const intl = useIntl();
Expand Down