-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add spacing to searchbar and simplify render conditions [FC-0062] #1461
fix: add spacing to searchbar and simplify render conditions [FC-0062] #1461
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 1052 1052
Lines 20462 20460 -2
Branches 4298 4382 +84
=======================================
- Hits 19086 19085 -1
+ Misses 1316 1312 -4
- Partials 60 63 +3 ☔ View full report in Codecov by Sentry. |
ed59ce9
to
68c8fce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Looks good to me. 👍
Adds padding between the search bar and the library list. Also, the render method was refactored to be a bit simpler. Backport of #1461
Description
This PR adds padding between the search bar and the library list.
Also, the render method was refactored to be a bit simpler.
Before
After
Additional Information
Testing instructions
Private ref: FAL-3931