Upgrade pymongo #290
Merged
Upgrade pymongo #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
218b310 to
9c7abc8
Compare
9c7abc8 to
f44e99e
Compare
68c18cf to
5651572
Compare
iamsobanjaved
approved these changes
Jun 26, 2024
awais786
reviewed
Jun 26, 2024
eventtracking/backends/mongodb.py
Outdated
| self.collection.ensure_index([('time', pymongo.DESCENDING)]) | ||
| self.collection.ensure_index('name') | ||
| # TODO: Remove pymongo3 backward compatibility code once pymongo4 upgrade is done | ||
| if pymongo.version_tuple[0] == 3: |
There was a problem hiding this comment.
suggestion: Add simple test to make sure its getting the right things depending on versions
There was a problem hiding this comment.
I have added a pin for pymongo version >=4.0.0
pymongo pin
now the legacy code is no longer needed.
a384867 to
87a2d42
Compare
87a2d42 to
48ef9a2
Compare
HassanJaveed84
approved these changes
Jul 2, 2024
vahid75
added a commit
to vahid75/event-routing-backends
that referenced
this pull request
Jul 9, 2024
…ster `event-tracking` which is on of this package dependencies, created a new version (openedx/event-tracking#290) which upgraded the pymongo version. So when we install this package the old style, we will get the latest event-tracking version with pymongo 4.4.0 which is incompatible with openedx open-release/quince.master. See issue openedx/tutor-contrib-aspects#891 fix-event-tracking_quince_clutter
vahid75
added a commit
to vahid75/event-routing-backends
that referenced
this pull request
Jul 9, 2024
`event-tracking` which is on of this package dependencies, created a new version (openedx/event-tracking#290) which upgraded the pymongo version. So when we install this package the old style, we will get the latest event-tracking version with pymongo 4.4.0 which is incompatible with openedx master. See issue openedx/tutor-contrib-aspects#891
vahid75
added a commit
to vahid75/event-routing-backends
that referenced
this pull request
Jul 9, 2024
`event-tracking` which is on of this package dependencies, created a new version (openedx/event-tracking#290) which upgraded the pymongo version. So when we install this package the old style, we will get the latest event-tracking version with pymongo 4.4.0 which is incompatible with openedx master. See issue openedx/tutor-contrib-aspects#891
vahid75
added a commit
to vahid75/event-routing-backends
that referenced
this pull request
Jul 21, 2024
`event-tracking` which is on of this package dependencies, created a new version (openedx/event-tracking#290) which upgraded the pymongo version. So when we install this package the old style, we will get the latest event-tracking version with pymongo 4.4.0 which is incompatible with openedx master. See issue openedx/tutor-contrib-aspects#891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading pymongo version in this PR.
There are some breaking changes in
4.4.0version of pymongohttps://pymongo.readthedocs.io/en/4.4.0/changelog.html#breaking-changes-in-4-0
which have been fixed in this PR.