fix pep8 and pylint errors #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
|
|
||
| course_search_location = ['i4x', dest_location.org, dest_location.course, | ||
| 'course', None |
There was a problem hiding this comment.
This is weird spacing. Prefer
location = [
'i4x',
...,
None
]
|
👍 once comments addressed |
|
Thanks, will change and squash |
Conflicts: cms/djangoapps/contentstore/views/course.py common/lib/xmodule/xmodule/tests/test_combined_open_ended.py lms/envs/common.py
|
👍 |
cgopalan
pushed a commit
to open-craft/edx-platform
that referenced
this pull request
Aug 29, 2017
* added student_view_data to HtmlBlock to allow html to be downloadable via the course blocks API * added tests for html xblock student_view_data
ny0m
added a commit
to open-craft/edx-platform
that referenced
this pull request
Aug 31, 2017
* added student_view_data to HtmlBlock to allow html to be downloadable via the course blocks API * added tests for html xblock student_view_data
ziafazal
pushed a commit
that referenced
this pull request
Dec 12, 2017
* added student_view_data to HtmlBlock to allow html to be downloadable via the course blocks API * added tests for html xblock student_view_data
andrey-canon
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Aug 3, 2018
And/rocket chat djangoapp
caesar2164
pushed a commit
to caesar2164/edx-platform
that referenced
this pull request
Dec 15, 2018
* stv/unfork/cms/comment: Remove useless comment fork
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sarina @wedaly
Fixes a bunch of pep8 and pylint violations. The hotfix will add some violations to master; this PR is meant to help offset that.