Jbau/bulk email faster tests #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| """ | |||
| Unit tests for handling email sending errors | |||
| """ | |||
|
|
|||
| from itertools import cycle | |||
There was a problem hiding this comment.
any day i get to learn a new itertools fn is a Good Day. 🐣
|
Looks 🙆♀️ to me 👍 |
|
7 seconds to run the tests. Much better. 👍 |
|
cool. |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Victor/capa cleanup Looks good. Yes, the code exec part will need more thought, particularly with respect to security.
andrey-canon
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Jul 25, 2018
Update rocketChat xblock to 0.2.16
kluo
pushed a commit
to kluo/edx-platform
that referenced
this pull request
Nov 30, 2018
Efficiency improvement for EnrollmentRosterView.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nedbat @sarina
I've made a mockery of test_err_handling.py. Can you see if it's faster now? I didn't change the semantics of the tests much, so coverage should remain the same.