Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in grading, if problem cannot be created, return score as none #711

Closed
wants to merge 1 commit into from

Conversation

adampalay
Copy link
Contributor

Conflicts:
lms/envs/dev.py

@brianhw
Copy link
Contributor

brianhw commented Sep 5, 2013

Looks reasonable to me.

@adampalay adampalay closed this Sep 5, 2013
@adampalay adampalay deleted the hotfix/adam/progress-page branch September 5, 2013 16:52
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
e-kolpakov referenced this pull request in open-craft/edx-platform Jun 22, 2016
YONK-324: move social_engagement app into separate repo
caesar2164 pushed a commit to caesar2164/edx-platform that referenced this pull request Oct 27, 2017
…yword-sub-text

Add keyword sub modal text link back to instructor email section
jfavellar90 pushed a commit to eduNEXT/edx-platform that referenced this pull request Apr 13, 2018
ENH: adding a setting that will dictate the sign in to either be direct to 3rd party auth or to normal login page
jfavellar90 pushed a commit to eduNEXT/edx-platform that referenced this pull request Apr 20, 2018
* Adding rocket chat xblock dependency and settings to it work properly
ENH: adding a setting that will dictate the sign in to either be direct to 3rd party auth or to normal login page
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
- Add radio role and aria-checked to button to enable screen reader use
Abdul-Muqadim-Arbisoft pushed a commit to edly-io/edx-platform that referenced this pull request May 8, 2024
The -m/--mount option makes it possible to bind-mount volumes at runtime. The
volumes are declared in a local/docker-compose.tmp.yml file. The problem with
this approach is when we want to bind-mount a volume to a service which is
specific to the dev context. For instance: the "learning" service when the MFE
plugin is enabled.

In such a case, starting the service triggers a call to `docker-compose stop`
in the local context. This call fails because the "learning" service does not
exist in the local context. Note that this issue only seems to occur with
docker-compose v1.

To resolve this issue, we create two additional filters for
the dev context, which emulate the behaviour of the local context. With this approach, we convert the -m/--mount arguments right after they are parsed. Because they are parsed just once, we can get rid of the de-duplication logic initially introduced with the COMPOSE_CLI_MOUNTS context.

Close openedx#711. Close also overhangio/tutor-mfe#57.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants