Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Course Modes to LMS #676

Merged
merged 3 commits into from
Aug 14, 2013
Merged

Add Course Modes to LMS #676

merged 3 commits into from
Aug 14, 2013

Conversation

dianakhuang
Copy link
Contributor

Related to PR #651, but not blocked by it. Adds a new djangoapp for maintaining varying course modes for courses.

@ormsbee

If no modes have been set in the table, returns the default mode
"""
found_course_modes = cls.objects.filter(course_id=course_id)
modes = [Mode(mode.mode_slug, mode.mode_display_name, mode.min_price, mode.suggested_prices) for mode in found_course_modes]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break into two lines pls?

@ormsbee
Copy link
Contributor

ormsbee commented Aug 14, 2013

I think we might change the naming at some point, but I have no better suggestions at the moment. Is there an admin.py with this?

Otherwise, no objections.

@dianakhuang
Copy link
Contributor Author

I forgot the admin file. I checked it out manually to make sure it works. Still good?

@ormsbee
Copy link
Contributor

ormsbee commented Aug 14, 2013

Yup.

dianakhuang added a commit that referenced this pull request Aug 14, 2013
@dianakhuang dianakhuang merged commit cc86fb3 into master Aug 14, 2013
@dianakhuang dianakhuang deleted the diana/course-modes branch August 14, 2013 19:33
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Mar 30, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Mar 30, 2016
mtyaka referenced this pull request in open-craft/edx-platform Apr 13, 2016
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
johanseto pushed a commit to nelc/edx-platform that referenced this pull request Jan 22, 2024
feat: generate valid passwords when using additional validators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants