-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Course Modes to LMS #676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianakhuang
referenced
this pull request
Aug 14, 2013
If no modes have been set in the table, returns the default mode | ||
""" | ||
found_course_modes = cls.objects.filter(course_id=course_id) | ||
modes = [Mode(mode.mode_slug, mode.mode_display_name, mode.min_price, mode.suggested_prices) for mode in found_course_modes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Break into two lines pls?
I think we might change the naming at some point, but I have no better suggestions at the moment. Is there an admin.py with this? Otherwise, no objections. |
I forgot the admin file. I checked it out manually to make sure it works. Still good? |
Yup. |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Feature/kfiedler/ocw links
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 30, 2016
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 30, 2016
mtyaka
referenced
this pull request
in open-craft/edx-platform
Apr 13, 2016
Bump hash for problem builder
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
MICROBA-1523
johanseto
pushed a commit
to nelc/edx-platform
that referenced
this pull request
Jan 22, 2024
feat: generate valid passwords when using additional validators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PR #651, but not blocked by it. Adds a new djangoapp for maintaining varying course modes for courses.
@ormsbee