Fix/adam/lms help button #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
Merged
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Fix IE bugs including schematic editor text alignment
mtyaka
referenced
this pull request
in open-craft/edx-platform
Apr 13, 2016
…dback-update-15 Diagnostic Feedback Version Tagging
dfrojas
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Aug 31, 2017
Mods to OLI event hander
jfavellar90
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Apr 20, 2018
Proversity/staging
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
…rse exit page (openedx#660)" (openedx#668) This reverts commit 55b3396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various issues with the help modal:
broken JS was causing multiple divs to show up, which was
a) ugly: https://edx-wiki.atlassian.net/browse/LMS-869
b) causing disgruntled students repeatedly to click submit, creating many duplicates of issues, creating headaches: (https://edx-wiki.atlassian.net/browse/LMS-854?jql=text%20~%20%22help%22)
Has the faq link point to the marketing site's faq if there's a marketing site. Otherwise to the LMS's /help page.
adds a dummy FEEDBACK_SUBMISSION_EMAIL to lms/envs/dev.py to help with debugging the modal
@gwprice @cpennington