Fixing padding issues #6551
Merged
Fixing padding issues #6551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1098,6 +1098,15 @@ | |||
| @include padding($baseline $baseline 0 $baseline); | |||
| border: 1px solid $gray-l5; | |||
| } | |||
|
|
|||
| .padded-content { | |||
| padding-left: $baseline !important; | |||
There was a problem hiding this comment.
Woah! Why the !important? Any way you can scope this with a more descriptive selector or its order in the cascade?
0238a94 to
9a82cfa
Compare
| @@ -560,6 +560,10 @@ | |||
|
|
|||
| .form-actions { | |||
| @include padding($baseline 0 $baseline 0); | |||
There was a problem hiding this comment.
NIT: no need to have all 4 values in this shorthand.
There was a problem hiding this comment.
NIT: no need to use the RTL include padding() mixin here (since all values are equal).
|
@clrux, thanks for the revisions. Aside from my small nits on RTL, this looks good. Once you clean those up, 👍 |
9a82cfa to
360324e
Compare
360324e to
e29f093
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the padding issues, @talbs @andy-armstrong @cahrens.