Adam/add defunct states for cart #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dfc79a to
00999af
Compare
|
@wedaly , @dianakhuang , may you please take a look? |
| if self.status in {"defunct-cart", "defunct-paying"}: | ||
| return | ||
|
|
||
| if self.status not in {"cart", "paying"}: |
There was a problem hiding this comment.
It might be slightly cleaner to use the ORDER_STATUS_MAP keys instead of hardcoding this. Something like:
acceptable_keys = set(ORDER_STATUS_MAP.keys())
|
Please add a unit test for the management command itself (can use temporary files to simulate the input). Other than that, 👍 |
| print "retired order {order_id} from status {old_status} to status {new_status}".format( | ||
| order_id = order.id, | ||
| old_status = old_status, | ||
| new_status = order.status, |
There was a problem hiding this comment.
These are a pep8 violation that is causing the Jenkins build to fail (no spaces around the equals signs here).
|
Other than that, 📦 : |
d6fa897 to
4f526a2
Compare
|
@wedaly , unit test added |
|
👍 |
add retire method to order class
4f526a2 to
abdae82
Compare
adampalay
added a commit
that referenced
this pull request
Dec 9, 2014
Adam/add defunct states for cart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dianakhuang
@wedaly
This PR introduces two more order statuses—"defunct-cart" and "defunct-paying"—to account for order rows that were sent through the payment processor but not updated in the db. It also adds a "retire" method to order objects, and adds a management command to "retire" lists of orders that should be made defunct.
https://openedx.atlassian.net/browse/ECOM-703