Remove get_preview_module. #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And replace calls with calls to load_preview_module.
|
👍 |
|
👍 (did not check out code and test it) |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Updated django-wiki to better handle relative wiki links.
Kelketek
referenced
this pull request
in open-craft/edx-platform
Sep 23, 2015
Updated Problem Builder hash
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 3, 2016
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 3, 2016
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 3, 2016
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 3, 2016
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Oct 12, 2016
…-fix Update free text response and submit-and-compare SHAs for score calculation fix
yoann-mroz
pushed a commit
to weuplearning/edx-platform
that referenced
this pull request
Nov 30, 2020
* Update many `docker` usages to be `docker-compose` to allow
multi-devstack support via setting of `COMPOSE_PROJECT_NAME`
connfiguration option in `options.local.mk`.
* Add network aliases for backwards-compatibility.
* Add several new Makefile targets:
+ dev.print-container.<service>
+ dev.ps
+ dev.stop[.<services>]
+ dev.kill[.<services>]
+ dev.down[.<services>]
+ dev.restart[.<services>]
+ dev.rm-stopped
* Using new targets, fix features that would break when using an
alternative `COMPOSE_PROJECT_NAME`.
* Utilize `COMPOSE_FILE` docker-compose environment variable
to set Docker Compose file list for all Makefile rules and scripts
used through the Makefile.
Co-authored-by: Adolfo R. Brandes <arbrandes@arbrand.es>
Co-authored-by: Kyle McCormick <kmccormick@edx.org>
rediris
pushed a commit
to gymnasium/edx-platform
that referenced
this pull request
Feb 25, 2021
[PATCH] Fix CAPA Problems
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And replace calls with calls to load_preview_module.
get_preview_module does nothing besides load_preview_module, with the same arguments, and in the same order. And they have different docstrings. And both of them were outdated.
ack-ed thorough the codebase, and ran cms tests - get_preview isn't used anywhere else.
@dmitchell @cahrens