Quiet mongoimport noise during tests #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| processes = [ | ||
| subprocess.Popen([ | ||
| 'mongoimport', '-d', dbname, '-c', | ||
| collection_prefix + collection, '--jsonArray', | ||
| '--file', | ||
| SplitModuleTest.COMMON_ROOT + '/test/data/splitmongo_json/' + collection + '.json' | ||
| ]) | ||
| ], | ||
| stderr=devnull, |
There was a problem hiding this comment.
Perhaps stifle only stdout and not stderr? It would be misleading if the external proc failed silently.
There was a problem hiding this comment.
I don't know what mongoimport does on failure, if anything goes to stderr. The best option would be to use .communicate() instead of .wait(), and to show the failing output if the subprocess fails.
There was a problem hiding this comment.
idk what communicate does and whether I needed the wait to ensure the tests don't begin w/o the db being init'd, but if you feel confident, I'd believe you, and I agree w/ the sentiment that it'd be better to show whatever error emerges.
|
OK, I changed it to .communicate(). Try it if you like. |
nedbat
added a commit
that referenced
this pull request
Jul 31, 2013
…ests Quiet mongoimport noise during tests
e-kolpakov
referenced
this pull request
in open-craft/edx-platform
Sep 17, 2015
XBlock-utils hash update
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 27, 2016
* stv/pin/scipy: Pin requirements for scipy/numpy
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mongoimport writes messages to stdout and we don't want to see those during tests. Please keep the tests quiet!
@dmitchell review?