Send e-mails when course creator status changes. #488
Conversation
|
@cahrens sorry, I'm not clear on this. Does this PR replace the other one? Or are these two PR's at different commit points on the same branch? Thanks |
|
This was a branch I made off of the first one. I sent a link to a diff On Monday I can submit the first one and rebase this. That should clear it On Thursday, July 25, 2013, chrisndodge wrote:
|
|
@chrisndodge I have rebased this pull request on master, now that the other one is merged. So the diff is now just the changed files. |
| @@ -0,0 +1,5 @@ | |||
| <%! from django.utils.translation import ugettext as _ %> | |||
|
|
|||
| ${_("Your request for course creation rights to edX Studio have been denied. If you believe this was in error, please contact: ")} | |||
There was a problem hiding this comment.
The I18N here is good, but - curious - how will the template decide which language to use here? Ideally, this would be part of some user preference. However, setting email language preferences is out-of-scope for this story :-)
There was a problem hiding this comment.
Hah, you are right. I have no idea how we will handle a user e-mail language preference.
Definitely TBD.
|
If we get this into today's RC, I presume there will have to be some DevOps configuration changes (STUDIO_REQUEST_EMAIL). If so, have you coordinated that with the DevOps team? Are we planning to remove HTTP auth on this release or is this work just 'anticipatory'? |
|
I have been in contact with Ed about STUDIO_REQUEST_EMAIL and also setting ENABLE_COURSE_CREATOR to True on Edge. HTPP Auth will be removed at the end, when everything is complete. This work can go in without the DevOps stuff being done. Until the final bit is enabled (and I run the script to populate the table), there is no impact. I'm hoping to squeeze all of that in once the release candidate is up, but if I don't make it, it will be fine. |
|
Btw, STAFF_EMAIL (the old name of the variable) was never actually set on edx's environment. So that code about showing an "email to create course" link on the dashboard was never being executed. You can see that on edx.org if you log in with a non-staff account. |
|
OK, +1, but do we need a CHANGELOG entry? |
|
I'll add a changelog entry. |
Send e-mails when course creator status changes.
Protect asciimath2jax in seq_contents, fix choiceresponse on CS169x
…_lockout_messaging_typos Fix typos in user log-in lockout message
fix(mobile api): add vip fields in user info response after patch
An e-mail will be sent on the following transitions:
unrequested, pending, or denied -> granted ("yo, you've got access").
granted -> denied ("yo, you're totally denied')
granted -> unrequested, pending ("yo, your access has been revoked")
https://edx-wiki.atlassian.net/browse/STUD-207