Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme by microsite #4107

Closed
wants to merge 1 commit into from
Closed

Theme by microsite #4107

wants to merge 1 commit into from

Conversation

akktis
Copy link

@akktis akktis commented Jun 16, 2014

Possibility to have one theme per microsite
Please review carefully i'm quit new in the edx code

Possibility to have one theme per microsite
@singingwolfboy
Copy link
Contributor

@papipsycho Thanks for the contribution! Before it can be reviewed, though, we need you to submit a signed contributor's agreement, as documented in the CONTRIBUTING file in the repository.

@akktis
Copy link
Author

akktis commented Jun 16, 2014

Ok i'll send it tomorow :)

@mhoeber
Copy link
Contributor

mhoeber commented Jun 25, 2014

backlogged DOC-628

@jtauber
Copy link
Contributor

jtauber commented Jun 26, 2014

@felipemontoya I'd love your input on this too, given your work on #3495

# Include the theme's templates in the template search paths
settings.TEMPLATE_DIRS.insert(0, theme_root / 'templates')
# Namespace the theme's static files to 'themes/<theme_name>' to
# amespace the theme's static files to 'themes/<theme_name>' to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is a duplicated line

@felipemontoya
Copy link
Member

@papipsycho I am not sure what you are trying to accomplish here. You can already override the templates in the microsite, using the edxmako.shortcuts.render_to_response.

Let me know if I'm missing something

@akktis
Copy link
Author

akktis commented Jun 29, 2014

Actually i'm trying to find a way to have one theme per subdomain,

like comp1.edx.org = theme1,
comp2.edx.org = theme2
comp3.edx.org = theme1

but actually my modification doens't work but if you have any idea your welcome

@jtauber
Copy link
Contributor

jtauber commented Jul 10, 2014

@papipsycho what you are trying to do is exactly what microsites already achieves so I'm going to close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants