-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme by microsite #4107
Theme by microsite #4107
Conversation
Possibility to have one theme per microsite
@papipsycho Thanks for the contribution! Before it can be reviewed, though, we need you to submit a signed contributor's agreement, as documented in the CONTRIBUTING file in the repository. |
Ok i'll send it tomorow :) |
backlogged DOC-628 |
@felipemontoya I'd love your input on this too, given your work on #3495 |
# Include the theme's templates in the template search paths | ||
settings.TEMPLATE_DIRS.insert(0, theme_root / 'templates') | ||
# Namespace the theme's static files to 'themes/<theme_name>' to | ||
# amespace the theme's static files to 'themes/<theme_name>' to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this is a duplicated line
@papipsycho I am not sure what you are trying to accomplish here. You can already override the templates in the microsite, using the edxmako.shortcuts.render_to_response. Let me know if I'm missing something |
Actually i'm trying to find a way to have one theme per subdomain, like comp1.edx.org = theme1, but actually my modification doens't work but if you have any idea your welcome |
@papipsycho what you are trying to do is exactly what microsites already achieves so I'm going to close this pull request. |
Possibility to have one theme per microsite
Please review carefully i'm quit new in the edx code