put block around main_vendor js in main_django.html #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be a no-op for edx-east, but allow edx-west to remove
vendor.js with a blank {% block %}
in our password_reset_confirm.html to fix a bug
|
seems okay to me, but you should probably run this by @cpennington. 👍 if he's okay with it. |
|
Thanks @jbau. Looks good here as well - I'd just echo @frrrances's thoughts on getting @cpennington's approval. 👍 |
|
@cpennington a quick ping on this one: its changes should be a no-op, as nothing else is using a main_vendor_js block. |
|
👍 |
jbau
added a commit
that referenced
this pull request
Jul 17, 2013
…ndor-js put block around main_vendor js in main_django.html
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Provide content QA (quality assessment) interface
kawaguchi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 6, 2015
Merge tag 'release-2015-10-01'
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
…regen-cert Fix KeyError: 'designation' error oversight
jfavellar90
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Apr 11, 2018
* ADD: microsite config file config and generation of file from microsite endpoint * ADD: comments * FIX: calling safe after microsite creation.
dgamanenko
referenced
this pull request
in raccoongang/edx-platform
Jun 14, 2018
* ADD: microsite config file config and generation of file from microsite endpoint * ADD: comments * FIX: calling safe after microsite creation.
xavierchan
added a commit
to xavierchan/edx-platform-1
that referenced
this pull request
May 20, 2019
MoisesGSalas
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Jan 12, 2022
…-arabic-translation [FAL-2358] Update 'View Course' arabic translation
jbcurtin
pushed a commit
to jbcurtin/edx-platform
that referenced
this pull request
Jan 31, 2022
…-arabic-translation [FAL-2358] Update 'View Course' arabic translation (cherry picked from commit 00c5165)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be a no-op for edx-east, but allow edx-west to remove
vendor.js (with an empty {% block %}) in our password_reset_confirm.html to fix a bug
@frrrances @talbs