Lettuce YouTube Check Improvements #3949
Conversation
| try: | ||
| response = requests.get(url, allow_redirects=False) | ||
| except requests.exceptions.ConnectionError: | ||
| print "EXCEPTION: Connection timed out for {0}".format(url) |
There was a problem hiding this comment.
Please clarify: Output of print will be seen both in Jenkins logs and local logs (on dev machine run)? Print is better than log?
There was a problem hiding this comment.
Yeah print Output will be seen on console. Log is better then print as print will pollute the console. Is there any log files being written by lettuce tests?
There was a problem hiding this comment.
They are should be, @jzoldak can you please clarify?
There was a problem hiding this comment.
yes, our pattern is to use log not print.
We display on the console output log level warning and up.
To see what the console would look like when youtube is not available, you can temporarily change the status code that is returned to something that will fail and do something like rake test:acceptance:cms:fast["--tag requires_stub_youtube -s 1"]
There was a problem hiding this comment.
LOGGER.warning("Connection Error. YouTube {0} service not available. Skipping this test.".format(name))
|
👍 |
|
👍 |
…ability-check Lettuce YouTube Check Improvements
No description provided.