Simplify save_grade and pass through answer_unknown

[VikParuchuri]

No description provided.

[jbau]

cool, i'll take a look

[jbau]

have a planning mtg now... will look soon.

[jbau]

How should we use "answer_unknown" as a POST var? Should it be set to "1" or "true" if there's no rubric selections?

[VikParuchuri]

@jbau It is sent from the JS to the peer_grading xmodule. It is true if the "I don't know" box is checked, false if not.

[jbau]

(hipchat is down for me, otherwise I'd discuss there)

Oh I see, it's already there. I thought it was a flag you just added.

[VikParuchuri]

Yeah, it was already there, it just wasn't properly routed until I noticed the bug.

[jbau]

I will cherry pick these over to stanford's release candidate branch so we can write the coffeescript against this

[VikParuchuri]

@natea Can you review this? Assigning to you.

[VikParuchuri]

@natea Did you get a chance to look at this?

[natea]

I started looking at it last week and saw that most of the changes are pep8
cleanups, but there are some changes which are not as trivial. Today I'll
run the tests against these changes to see if there are any issues.

On Thu, Jul 25, 2013 at 11:06 AM, Vik Paruchuri notifications@github.comwrote:

@natea https://github.com/natea Did you get a chance to look at this?

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/392#issuecomment-21560447
.

nate@appsembler.com
+1 (617) 517-4953
http://twitter.com/natea | http://linkedin.com/in/natea

[VikParuchuri]

Would be good to merge this in this week if possible.

[natea]

ok, i'll take a look at it tomorrow (didn't get to it today)

---

Please excuse my brevity. I'm trying to win The Email Game!

-----Original Message-----

Re: [edx-platform] Simplify save_grade and pass through answer_unknown (#392)
From: Vik Paruchuri <notifications@github.com>
To: edx/edx-platform <edx-platform@noreply.github.com>
Cc: Nate Aune <nate@noderabbit.com>
Thursday, July 25, 2013 at 3:46PM

Would be good to merge this in this week if possible.
—
Reply to this email directly or view it on GitHub.

 

[VikParuchuri]

@natea Any chance to look?

[natea]

These changes all look fine to me. Ready to merge!