vagrant: Always mount node_modules folder after Vagrant NFS mount
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. Thanks for the code, and also for helping out Andrés out! |
singingwolfboy
added a commit
that referenced
this pull request
Jul 12, 2013
vagrant: Always mount `node_modules` folder after Vagrant NFS mount
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
fixed course name title bar bug
antoviaque
referenced
this pull request
in open-craft/edx-platform
Feb 10, 2015
Merge release in master
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
…-upstream-user-menu-fix pushed the unit ribbon in lms courseware to back which brought the us…
xavierchan
pushed a commit
to xavierchan/edx-platform-1
that referenced
this pull request
May 5, 2019
i18n 5.5 update
Agrendalath
pushed a commit
that referenced
this pull request
Aug 18, 2021
This PR updates the lti-consumer-xblock version to a new commit that contains the backported fix from openedx/xblock-lti-consumer#150
jbcurtin
pushed a commit
to jbcurtin/edx-platform
that referenced
this pull request
Jan 31, 2022
This PR updates the lti-consumer-xblock version to a new commit that contains the backported fix from openedx/xblock-lti-consumer#150 (cherry picked from commit 9612bad)
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/opt/edx/edx-platform/node_modulesneeds to be always mounted upon a VM boot, after Vagrant has manually mounted the repository code from the host. Since the mount made by Vagrant isn't part offstab, we wait for/opt/edx/edx-platformto be mounted before mounting its subdirectory.Issue reported in https://groups.google.com/d/msg/edx-code/FK4I2YmduqI/xrX8s0pD620J