-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add API to return list of downstream contexts for an upstream [FC-0076] #36253
base: master
Are you sure you want to change the base?
feat: add API to return list of downstream contexts for an upstream [FC-0076] #36253
Conversation
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
c7ed62d
to
3738603
Compare
d4ad01b
to
4516aa2
Compare
4516aa2
to
88e9b08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Works as expected, just left some suggestions.
links = PublishableEntityLink.get_by_upstream_usage_key(upstream_usage_key=usage_key) | ||
downstream_key_list = [link.downstream_context_key for link in links] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
links = PublishableEntityLink.get_by_upstream_usage_key(upstream_usage_key=usage_key) | |
downstream_key_list = [link.downstream_context_key for link in links] | |
downstream_key_list = PublishableEntityLink.get_by_upstream_usage_key( | |
upstream_usage_key=usage_key | |
).values_list('downstream_context_key', flat=True) | |
result = [] | ||
for context_key, count in counter.most_common(): | ||
# The following code only can handle the correct display_name for Courses as context | ||
course = modulestore().get_course(context_key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can search for course names using CourseOverview table. Something like below:
CourseOverview.objecs.filter(id__in=context_key_list).values_list('display_name', 'id')
Description
This PR adds the api for listing downstream contexts for a given publishable entity.
Additional Information
Testing Instructions
Private ref: FAL-4005